[iot-pmc] [CQ 16768] fog05 plugins

[emo-ip-team@xxxxxxxxxxx]

http://dev.eclipse.org/ipzilla/show_bug.cgi?id=16768





--- Comment #4 from Gabriele Baldoni <gabriele.baldoni@xxxxxxxxxxxxxx>  2018-06-21 11:11:54 ---
(In reply to comment #3)
> Hi Gabriele,
> 
> it looks like the archive you have attached contains several non-source code
> files. In particular, I believe that the whole __MACOSX folder is not part of
> the source code as well as the .DS_Store file in the plugins folder. Can you
> check?
> 
> I have also noticed that the python source files seem to import classes from
> other packages (don't know if this is the right term in python) that seem to be
> part of fog05 but do not comply with eclipse package name conventions. For
> example, the file brctl/brctl_plugin.py starts like this:
> 
> import sys
> import os
> import uuid
> import struct
> import json
> from fog05.interfaces.NetworkPlugin import *
> from jinja2 import Environment
> import socket
> 
> Will fog05.interfaces.NetworkPlugin be part of the fog05 project code?
> 
> The project handbook [1] seems to suggest (require?) that package names (if
> supported by the language) start off with "org.eclipse" and then contain the
> project short name, which would resolve to "org.eclipse.fog05" in your case.
> 
> [1] https://www.eclipse.org/projects/handbook/#trademarks-code
> 

Hi Kai,

I'll remove the macos stuffs and upload a new file, sorry for that.

Yes the plugins are importing interfaces from the main fog05 code (this is why
I have contributed them separately), in python it is not possible to have a
something like org.eclipse.fog05 (for example eclipse paho on python is just
import paho) due to the package structure for python projects.

All the import that refer to fog05 are part of the other CQ
(https://dev.eclipse.org/ipzilla/show_bug.cgi?id=16662)  

I will fix the problem with non-source files and I'll update a new zip file


-- 
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.