[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[iot-pmc] [CQ 16768] fog05 plugins
|
http://dev.eclipse.org/ipzilla/show_bug.cgi?id=16768
Kai Hudalla <kai.hudalla@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kai.hudalla@xxxxxxxxxxxx
--- Comment #3 from Kai Hudalla <kai.hudalla@xxxxxxxxxxxx> 2018-06-20 03:02:25 ---
Hi Gabriele,
it looks like the archive you have attached contains several non-source code
files. In particular, I believe that the whole __MACOSX folder is not part of
the source code as well as the .DS_Store file in the plugins folder. Can you
check?
I have also noticed that the python source files seem to import classes from
other packages (don't know if this is the right term in python) that seem to be
part of fog05 but do not comply with eclipse package name conventions. For
example, the file brctl/brctl_plugin.py starts like this:
import sys
import os
import uuid
import struct
import json
from fog05.interfaces.NetworkPlugin import *
from jinja2 import Environment
import socket
Will fog05.interfaces.NetworkPlugin be part of the fog05 project code?
The project handbook [1] seems to suggest (require?) that package names (if
supported by the language) start off with "org.eclipse" and then contain the
project short name, which would resolve to "org.eclipse.fog05" in your case.
[1] https://www.eclipse.org/projects/handbook/#trademarks-code
--
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.
