Re: [incubation] Contributions via GitHub, how to handle squash commits

[Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>]

Thank you for that as well! I didn't know that such a mapping is possible. It probably would make sense to make the ip tooling aware of all GitHub mail addresses having write access to a repository by default, since only committers do have write access anyway.

Theoretically, these tweaks are corner cases. The Eclipse Foundation Account system keeps track of all email address changes and feeds this information into the process that grabs the data for the IP Log Generator and the charts that appear on the project pages. The same data is fed to the processes that populate http://dashboard.eclipse.org (but it's a separate process).

Committers are required to use the email address registered in their Eclipse Foundation Account. Similarly, contributors must use the email address that's associated with their Eclipse Foundation Account and corresponding ECA.

 

Since a squash commit actually is a NEW commit, the ip-validation has to be aware of that. IMHO this case is NOT explained anywhere on the Eclipse wiki nor in the handbook. This is why is used this list.

The process that harvests data for the IP Log Generator just looks at what's there. Squash commits are just commits and so I don't believe that there's anything special about them from that perspective.

From the perspective of the ip-validation GitHub hook that checks that the author has an ECA and has signed off, I don't think that there's any work to do. The squashed commits would have all had to pass validation, so there shouldn't be any exposure. If multiple developers are involved in the work that gets squashed, it would be good to ensure that they're all noted via "Also-by" entries in the commit message. If you feel that there is a concern, open a bug against Community/GitHub.

FWIW, note that I normally notice and fix discrepancies when I review an IP Log. Like I said, the different email addresses tend to be relatively rare anomalies and there tends to be fewer of them as a project becomes established at the Eclipse Foundation.

HTH,

Wayne

--

Wayne Beaton

Director of Open Source Projects

The Eclipse Foundation