Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-dev] [ice-build] [eclipse/ice] 549c8b: Began updating the UI to use IEntry.

Alex,

I would like to make sure that this is consistent with the larger UI refactoring that I'm working on. We need an IEntryComposite interface that is obtained using some sort of provider so that we can do something like

ArrayList<IEntryCompositeProvider> providers = IEntryCompositeProvider.getProviders();

and then search that list for a provider based on type and context by

// Prepare to use the default provider, which will switch based on file, string types, etc.
IEntryCompositeProvider provider = new DefaultEntryCompositeProvider();
// Attempt to find a custom Entry rendering provider if the context is set.
if (entry.getContext().isEmpty()) {
   // Do a linear search over the providers to find the one with a name that matches the Entry's context. Ideally we would optimize this with a map since over the life of the program it would get very expensive.
   for (IEntryCompositeProvider otherProvider : providers) {
        if (otherProvider.getName().equals(entry.getContext()) {
           provider = otherProvider;
           break;
        }
   }
}
// Create the IEntryComposite
provider.createComposite(entry,<other arguments like FormToolKits, etc.>);

The IEntryCompositeProviders will be made available in the extension registry and hopefully later via the annotation engine.

Jay

On Mon, Jan 18, 2016 at 12:20 PM, GitHub <noreply@xxxxxxxxxx> wrote:
  Branch: refs/heads/mccaskey/entryRefactor
  Home:   https://github.com/eclipse/ice
  Commit: 549c8b4ce861fa450b3009f80a713e57ce149248
      https://github.com/eclipse/ice/commit/549c8b4ce861fa450b3009f80a713e57ce149248
  Author: amccaskey <mccaskeyaj@xxxxxxxx>
  Date:   2016-01-18 (Mon, 18 Jan 2016)

  Changed paths:
    M org.eclipse.ice.client.widgets.test/META-INF/MANIFEST.MF
    M org.eclipse.ice.client.widgets.test/src/org/eclipse/ice/client/widgets/test/EntryCompositeTester.java
    M org.eclipse.ice.client.widgets/plugin.xml
    A org.eclipse.ice.client.widgets/schema/entryComposite.exsd
    M org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/DataComponentComposite.java
    A org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/DiscreteEntryComposite.java
    M org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/EntryComposite.java
    A org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ExecutableEntryComposite.java
    A org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/FileEntryComposite.java
    M org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEDataComponentDetailsPage.java
    A org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/StringEntryComposite.java
    A org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/old_EntryComposite.java
    M org.eclipse.ice.datastructures/src/org/eclipse/ice/datastructures/entry/AbstractEntry.java
    M org.eclipse.ice.datastructures/src/org/eclipse/ice/datastructures/entry/DiscreteEntry.java
    M org.eclipse.ice.datastructures/src/org/eclipse/ice/datastructures/entry/FileEntry.java
    M org.eclipse.ice.datastructures/src/org/eclipse/ice/datastructures/entry/StringEntry.java

  Log Message:
  -----------
  Began updating the UI to use IEntry.

Setup EntryComposite to be abstract, with subclasses implementing render
method. Created EntryComposite subclasses for IEntry realizations.
Exposed those EntryComposites to Extension Registry and created via
context id for IEntry. Not finished fixing a few bugs related to
refresh.

Signed-off-by: amccaskey <mccaskeyaj@xxxxxxxx>



_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build




--
Jay Jay Billings
Oak Ridge National Laboratory
Twitter Handle: @jayjaybillings

Back to the top