| Re: [ice-dev] [ice-build] [eclipse/ice] eb174f: Added a setEventListener(event, listener) method t... |
That's a separate question. We can add user controlled layouts down the road.
I think we should do the expansion by default. It should just happen automatically. We should use as much real estate as possible to expose as much information as possible.
Jay
On Apr 9, 2015 10:18 AM, "Jordan Deyton" <deytonjh@xxxxxxxx> wrote:
>
> Technically, yes. GridData have a "verticalSpan" property that you can use to do this. The question is how we expose this property (and other layout properties) to the user.
>
>
> Jordan
>
> Jordan Deyton
> Oak Ridge National Laboratory
> Telephone: (865) 574-1091
> Email: deytonjh@xxxxxxxx
>
> On 4/9/2015 10:15 AM, Jay Jay Billings wrote:
>>
>> That's really cool.
>>
>> Here's another idea: is it possible to have "remainder" picture expand across both rows? So that plots like the VisIt picture are twice the height?
>>
>> Jay
>>
>> On Apr 9, 2015 10:01 AM, "Jordan Deyton" <deytonjh@xxxxxxxx> wrote:
>>>
>>> After playing around with it for about 30 minutes, I got my suggestion working in a local branch. The cool thing is it works with the VisIt plots, too, simply by returning the correct child Composite (a Canvas in both cases).
>>>
>>> Jordan
>>>
>>> Jordan Deyton
>>> Oak Ridge National Laboratory
>>> Telephone: (865) 574-1091
>>> Email: deytonjh@xxxxxxxx
>>>
>>> On 4/9/2015 9:30 AM, Jay Jay Billings wrote:
>>>>
>>>> That's certainly fine by me. What ever is most appropriate.
>>>>
>>>> Jay
>>>>
>>>> On Thu, Apr 9, 2015 at 9:16 AM, Jordan Deyton <deytonjh@xxxxxxxx> wrote:
>>>>>
>>>>> I feel like SWT or java.util Listeners are too specific or nitty-gritty for IPlot implementations to deal with.
>>>>>
>>>>> I think a better solution might be to have the draw method return a reference to the drawn child Composite, i.e. the Composite that should (a) have the close button drawn over it, (b) have a context menu added to it, or (c) get typed listeners registered with it.
>>>>>
>>>>> There's also currently no way to remove a listener from the IPlot. I say we just let the ICEResourcePage directly manage the listeners and keep IPlot as simple as possible.
>>>>>
>>>>> Jordan
>>>>>
>>>>> Jordan Deyton
>>>>> Oak Ridge National Laboratory
>>>>> Telephone: (865) 574-1091
>>>>> Email: deytonjh@xxxxxxxx
>>>>>
>>>>> On 3/31/2015 2:25 PM, GitHub wrote:
>>>>>>
>>>>>> Branch: refs/heads/anna/gridlayout
>>>>>> Home: https://github.com/eclipse/ice
>>>>>> Commit: eb174f24bece377341e96619b05f078bd7516e10
>>>>>> https://github.com/eclipse/ice/commit/eb174f24bece377341e96619b05f078bd7516e10
>>>>>> Author: Anna Wojtowicz <wojtowicza@xxxxxxxx>
>>>>>> Date: 2015-03-31 (Tue, 31 Mar 2015)
>>>>>>
>>>>>> Changed paths:
>>>>>> M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/viz/service/IPlot.java
>>>>>> M src/org.eclipse.ice.viz.service.paraview/src/org/eclipse/ice/viz/service/paraview/ParaViewPlot.java
>>>>>> M src/org.eclipse.ice.viz.service.visit/src/org/eclipse/ice/viz/service/visit/VisItPlot.java
>>>>>> M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/csv/CSVPlot.java
>>>>>> M src/org.eclipse.ice.viz/src/org/eclipse/ice/viz/plotviewer/CSVPlotEditor.java
>>>>>>
>>>>>> Log Message:
>>>>>> -----------
>>>>>> Added a setEventListener(event, listener) method to the IPlot interface
>>>>>> and plot classes. Implemented it for CSVPlot to add listeners on the
>>>>>> plot canvas (CSVPlotEditor.setPlotCanvasListener(...)).
>>>>>>
>>>>>> Signed-off-by: Anna Wojtowicz <wojtowicza@xxxxxxxx>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> ice-build mailing list
>>>>>> ice-build@xxxxxxxxxxx
>>>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>>>> https://dev.eclipse.org/mailman/listinfo/ice-build
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> ice-build mailing list
>>>>> ice-build@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/ice-build
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Jay Jay Billings
>>>> Oak Ridge National Laboratory
>>>> Twitter Handle: @jayjaybillings
>>>>
>>>>
>>>> _______________________________________________
>>>> ice-dev mailing list
>>>> ice-dev@xxxxxxxxxxx
>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/ice-dev
>>>
>>>
>>>
>>> _______________________________________________
>>> ice-dev mailing list
>>> ice-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/ice-dev
>>
>>
>>
>> _______________________________________________
>> ice-dev mailing list
>> ice-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/ice-dev
>
>
>
> _______________________________________________
> ice-dev mailing list
> ice-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ice-dev