Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-dev] [ice-build] [eclipse/ice] eb174f: Added a setEventListener(event, listener) method t...
After playing around with it for about 30 minutes, I got my suggestion working in a local branch. The cool thing is it works with the VisIt plots, too, simply by returning the correct child Composite (a Canvas in both cases).

Jordan
Jordan Deyton
Oak Ridge National Laboratory
Telephone: (865) 574-1091
Email: deytonjh@xxxxxxxx
On 4/9/2015 9:30 AM, Jay Jay Billings wrote:
That's certainly fine by me. What ever is most appropriate.

Jay

On Thu, Apr 9, 2015 at 9:16 AM, Jordan Deyton <deytonjh@xxxxxxxx> wrote:
I feel like SWT or java.util Listeners are too specific or nitty-gritty for IPlot implementations to deal with.

I think a better solution might be to have the draw method return a reference to the drawn child Composite, i.e. the Composite that should (a) have the close button drawn over it, (b) have a context menu added to it, or (c) get typed listeners registered with it.

There's also currently no way to remove a listener from the IPlot. I say we just let the ICEResourcePage directly manage the listeners and keep IPlot as simple as possible.

Jordan
Jordan Deyton
Oak Ridge National Laboratory
Telephone: (865) 574-1091
Email: deytonjh@xxxxxxxx
On 3/31/2015 2:25 PM, GitHub wrote:
  Branch: refs/heads/anna/gridlayout
  Home:   https://github.com/eclipse/ice
  Commit: eb174f24bece377341e96619b05f078bd7516e10
      https://github.com/eclipse/ice/commit/eb174f24bece377341e96619b05f078bd7516e10
  Author: Anna Wojtowicz <wojtowicza@xxxxxxxx>
  Date:   2015-03-31 (Tue, 31 Mar 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/viz/service/IPlot.java
    M src/org.eclipse.ice.viz.service.paraview/src/org/eclipse/ice/viz/service/paraview/ParaViewPlot.java
    M src/org.eclipse.ice.viz.service.visit/src/org/eclipse/ice/viz/service/visit/VisItPlot.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/csv/CSVPlot.java
    M src/org.eclipse.ice.viz/src/org/eclipse/ice/viz/plotviewer/CSVPlotEditor.java

  Log Message:
  -----------
  Added a setEventListener(event, listener) method to the IPlot interface
and plot classes. Implemented it for CSVPlot to add listeners on the
plot canvas (CSVPlotEditor.setPlotCanvasListener(...)).

Signed-off-by: Anna Wojtowicz <wojtowicza@xxxxxxxx>





_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build


_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build




--
Jay Jay Billings
Oak Ridge National Laboratory
Twitter Handle: @jayjaybillings


_______________________________________________
ice-dev mailing list
ice-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-dev

Attachment: tmp.png
Description: PNG image

Back to the top