Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-dev] Check out test omission in Luna branch?
Jay,

I just reverted it to the previous code that simulates mouse clicks. It was the only instance in the test class where SWTBot was used (subsequent SWTBot calls would always fail).

I couldn't get the test code to fail after switching the branch and the target platform. I tried it with the commented code, with the commented code uncommented, or with the change I made.

Frankly, I'm not sure if it's worth investing so much time into figuring out the intricacies of SWTBot given my current workload, so I just took out the SWTBot code. However, everything should still call the current Display in order to run on the UI thread as necessary.

Basically what I was doing in the tests was making sure that (1) the AnalysisToolComposite's ToolBar and its dropdown menus were being populated and enabled/disabled correctly, something that SWTBot can't do very well, and (2) the proper AnalysisViews were brought to the front by clicking those dropdown menu items, something that SWTBot could potentially do.

Jordan
Jordan Deyton
Oak Ridge National Laboratory
Telephone: (865) 574-1091
Email: deytonjh@xxxxxxxx
On 1/13/2015 2:48 PM, Jay Jay Billings wrote:
Jordan,

I had to comment out a part of the AnalysisToolCompositeTester that was failing with Java 8. It isn't clear what this is supposed to do anyway, so I decided to kill it. Can you review it please? It fails with an SWTBot WidgetNotFoundException on line 386 or so.

If we don't really need that part of the code, let me know and I will get back to trying to fix the Luna build so we can switch to the new target. If not, I'll try to figure out what we need to do to rewrite this whole test.

Jay

--
Jay Jay Billings
Oak Ridge National Laboratory
Twitter Handle: @jayjaybillings


_______________________________________________
ice-dev mailing list
ice-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-dev

Attachment: luna-error-free.png
Description: PNG image

Back to the top