Hi,
I recommend that we move the plugin source code into the main GlassFish repository and keep it maintained with GlassFish Server itself.
I reviewed the status of the embedded GF plugin and I found out the following:
- The plugin source code in https://github.com/eclipse-ee4j/glassfish-maven-embedded-plugin is more or less being updated, mostly thanks to the dependabot, although it's not ideal. Currently it depends on GF Embedded 7.0.7 while there's already 7.0.8
- The last released version of the plugin is 5.1, released in 2019. Since then, in the source code repo, the maven artifact name was changed and the version in the master branch is 7.0-SNAPSHOT. But there's no released version after 5.1
- The plugin more or less works. I've created 2 PRs to fix the plugin to work with blank configuration, so that it can be used to run an app even if not defined in the pom, with just mvn embedded-glassfish:run. It requires to add some --add-opens in MAVEN_OPTS environment variable, but this is an issue with GF Embedded, not with the plugin itself
- The documentation is maintained as part of the GlassFish Embedded documentation in the main GlassFish repository: https://github.com/eclipse-ee4j/glassfish/tree/master/docs/embedded-server-guide
Moving the plugin source code to the main repo would help us keep it maintained and release a new version together with GlassFish server. It would also make sense to have the documentation and the source code in the same repo so that we can easily keep the docs and the source code in sync.
What do you think?
All the best,Ondro Mihalyi
Director, Jakarta EE expert
Omnifish OÜ, Narva mnt 5, 10117 Tallinn, Estonia | VAT: EE102487932
