[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [glassfish-dev] Official Eclipse GlassFish Docker Images
|
The original GlassFish image repository is abandoned, because
originally it was created, published and maintained by AWS, using
Oracle GlassFish 4. Many years later we asked if we could adopt it
and continue with Eclipse GlassFish (concretely Arjan asked first),
DockerHub team agreed and gave us some advice how to do that.
By GCR you mean Google Container
Registry? Not sure why you mentioned that, maybe I misunderstood
something.
I am interested in the quality of the
image; I had to invest quite lot of work to pass DockerHub rules
to make our docker files compliant. There is also quite strong
community which was really nice and tried to review dockerfiles.
DockerHub Official Image Library has some standards we have to
keep, ie. they use git hashes to refer the history of the concrete
image version (not only GF version). It took me a while until I
understood why and how it works. Finally they build and test
images on their own for all platforms.
Under Eclipse nobody gives a damn what
we push. This is "out of the box" service of DockerHub just for
DockerHub Official Images (see the link to the documentation I
have sent in the previous message).
>> I think it’s best for all the
code to be inside the Eclipse GlassFish repository
If you mean GitHub, it is a bad idea.
The reason is that the docker image is a standalone product which
uses GlassFish and has it's own lifecycle. Look also to other
projects, they always keep docker images in a standalone git
repository (if they mean it seriously).
I believe we all pretty much understand what
an official Docker Hub image is. Many of the runtime
vendors have one as you noted and there are several for
Eclipse Foundation projects. The objective here should be
to publish an official Docker Hub image for whom the
maintainer is the Eclipse GlassFish project. I think the
Foundation can help with all that. If this was always the
case, I believe the current situation would not have
happened at all, with the GlassFish image labeled
“abandoned”.
I think as an interim using GCR is fine. That
would clearly be under an Eclipse Foundation/EE4J account.
In either case, I think it’s best for all the
code to be inside the Eclipse GlassFish repository. Is
there a reason why that is not what is proposed in the
issue?
Hi Steve and Reza,
thank you both for your emails!
There is yet another difference
between "official docker library image" and "official
eclipse-ee4j image".
The docker library contains
images checked by DockerHub, they have some quality
requirements (see the PR, checkboxes) and Docker Hub offers
them as "official DockerHub library images". They are also
tested by DockeHub's GitHub actions. These images must be
reproducible and overwriting is possible just for serious
security reasons, the source repository must keep history,
etc.
Here is also the partial list
of "official library images" - you can find there also
Jetty, TomEE, Tomcat, Open Liberty, WebSphere Liberty:
The omnifish/glassfish or
eclipse-ee4j/glassfish images are not tested by DockerHub
and DockerHub doesn't guarantee anything (from the DockerHub
point of view), it is just OmniFish/Eclipse's responsibility
whatever we upload. Images can be overwritten at any time
and they are not "official" in the meaning of Docker Hub
definition, just "official" in a meaning of OmniFish/Eclipse
Foundation.
So first we should probably ask
for the approval of PMC/PMO with a note that we would like
to follow Jetty's example.
Simply said, it is not just about
the repository name - yet this thing: the repository name
"glassfish" is rather an ID of the image, than it's name in
the copyright meaning. The name in it's documentation will
always be Eclipse GlassFish, same also in all log files.
Again, I would like to use Jetty as a "pattern to follow".
David.
On 12. 05. 23 13:40, Steve
Millidge (Payara) wrote:
Hi Reza,
To be honest I
don’t know how difficult it is to get approval from
Eclipse to use simply glassfish at Docker Hub. I agree
it would be better. The handbook says it needs PMC
and/or PMO approval. I assume that is just to check
that Eclipse is happy from a trademark perspective. I
know they do have registered the bare GlassFish
trademark Eclipse Foundation
Trademarks | The Eclipse Foundation (as they also
have with Jetty).
I will raise with Ivar as part of the PMC to see what
the process is in detail.
Steve
How
difficult would it be to use simply glassfish as
the image name? The reason is that as you know,
GlassFish is still better understood (and
perhaps easier to understand) than Eclipse
GlassFish. I imagine Jetty had the same issue
and it seems they have sorted it out in Docker
Hub.
Hi David,
Looks like you
have done some good work there and I think it
would be a good thing to have an Eclipse GlassFish
docker image.
I also agree
that to follow the Eclipse Development Process the
source code of any image must be in a GlassFish
project repository. The Project Handbook has
guidance on External Resources see Eclipse Project
Handbook | The Eclipse Foundation and for
Docker Hub specifically Eclipse Project
Handbook | The Eclipse Foundation. As long as
the guidelines are followed RE: Docker Hub I support
moving the source into the project and hosting the
image on Docker Hub. Reading the guidelines having a
dockerhub name that is not eclipseglassfish or some
variant of requires PMC and/or PMO approval.
Thanks
Steve
Hi GlassFish developers!
OmniFish did some
efforts for the official Eclipse GlassFish Docker
Image, however things are not so simple as we would
wish. To make everything correct I have created the
issue on GitLab: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3138
I would like to know
your opinion, especially
- if you would like to
use the official Eclipse GlassFish Docker Image
- if you would like to
contribute to the official Eclipse GlassFish Docker
Image
- if you have any
thoughts about it
I look forward to your
responses and have a nice Friday!
--
David Matejcek | OmniFish
david.matejcek@xxxxxxxxxxx
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev
--
David Matejcek | OmniFish
david.matejcek@xxxxxxxxxxx
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev