Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] Official Eclipse GlassFish Docker Images

Hi Steve and Reza,

thank you both for your emails!

There is yet another difference between "official docker library image" and "official eclipse-ee4j image".

The docker library contains images checked by DockerHub, they have some quality requirements (see the PR, checkboxes) and Docker Hub offers them as "official DockerHub library images". They are also tested by DockeHub's GitHub actions. These images must be reproducible and overwriting is possible just for serious security reasons, the source repository must keep history, etc.
Here is also the partial list of "official library images" - you can find there also Jetty, TomEE, Tomcat, Open Liberty, WebSphere Liberty:

The omnifish/glassfish or eclipse-ee4j/glassfish images are not tested by DockerHub and DockerHub doesn't guarantee anything (from the DockerHub point of view), it is just OmniFish/Eclipse's responsibility whatever we upload. Images can be overwritten at any time and they are not "official" in the meaning of Docker Hub definition, just "official" in a meaning of OmniFish/Eclipse Foundation.

So first we should probably ask for the approval of PMC/PMO with a note that we would like to follow Jetty's example.

Simply said, it is not just about the repository name - yet this thing: the repository name "glassfish" is rather an ID of the image, than it's name in the copyright meaning. The name in it's documentation will always be Eclipse GlassFish, same also in all log files. Again, I would like to use Jetty as a "pattern to follow".

David.

On 12. 05. 23 13:40, Steve Millidge (Payara) wrote:

Hi Reza,

 

To be honest I don’t know how difficult it is to get approval from Eclipse to use simply glassfish at Docker Hub. I agree it would be better. The handbook says it needs PMC and/or PMO approval. I assume that is just to check that Eclipse is happy from a trademark perspective. I know they do have registered the bare GlassFish trademark Eclipse Foundation Trademarks | The Eclipse Foundation (as they also have with Jetty). I will raise with Ivar as part of the PMC to see what the process is in detail.

 

Steve

 

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of reza_rahman@xxxxxxxxx
Sent: Friday, May 12, 2023 12:26 PM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Official Eclipse GlassFish Docker Images

 

Steve,

 

How difficult would it be to use simply glassfish as the image name? The reason is that as you know, GlassFish is still better understood (and perhaps easier to understand) than Eclipse GlassFish. I imagine Jetty had the same issue and it seems they have sorted it out in Docker Hub.

 

If I am understanding correctly, you are suggesting all the Docker code be moved under here, correct: https://github.com/eclipse-ee4j/glassfish? That would seem right to me

 

Thanks,

Reza

 


From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> on behalf of Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>
Sent: Friday, May 12, 2023 5:10 AM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Official Eclipse GlassFish Docker Images

 

Hi David,

 

Looks like you have done some good work there and I think it would be a good thing to have an Eclipse GlassFish docker image.

 

I also agree that to follow the Eclipse Development Process the source code of any image must be in a GlassFish project repository. The Project Handbook has guidance on External Resources see Eclipse Project Handbook | The Eclipse Foundation and for Docker Hub specifically Eclipse Project Handbook | The Eclipse Foundation. As long as the guidelines are followed RE: Docker Hub I support moving the source into the project and hosting the image on Docker Hub. Reading the guidelines having a dockerhub name that is not eclipseglassfish or some variant of requires PMC and/or PMO approval.

 

Thanks

 

Steve

 

 

 

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of David Matejcek
Sent: Friday, May 12, 2023 8:37 AM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: [glassfish-dev] Official Eclipse GlassFish Docker Images

 

Hi GlassFish developers!

OmniFish did some efforts for the official Eclipse GlassFish Docker Image, however things are not so simple as we would wish. To make everything correct I have created the issue on GitLab: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3138

I would like to know your opinion, especially

- if you would like to use the official Eclipse GlassFish Docker Image

- if you would like to contribute to the official Eclipse GlassFish Docker Image

- if you have any thoughts about it

I look forward to your responses and have a nice Friday!

-- 
David Matejcek | OmniFish
david.matejcek@xxxxxxxxxxx

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


-- 
David Matejcek | OmniFish
david.matejcek@xxxxxxxxxxx

Back to the top