| Re: [glassfish-dev] GlassFish 6 & 7 docs artifacts missing in Maven Central |
I recommend to look inside, because I have doubts if 6.2.5
doesn't just reuse 7.0.0 docs with replaced version number ... ? I
may be wrong ...
If I understand it correctly, PUBLISH isn't needed anymore. The /glassfish-docs-publish job builds and deploys the docs distribution artifacts into Maven Central, into the staging area.
It's now enough to approve the org.glassfish.docs:distribution artifacts staged in Maven Central.
Dear committers, can you please review and approve deployment of the org.glassfish.docs:distribution version 6.2.5 and 7.0.0 in Maven Central Nexus repository?
Then we can merge my PR https://github.com/eclipse-ee4j/glassfish/pull/24238, which would trigger an update of the website. This would build the website, including downloading docs distributions for all GF versions (5.1, 6.2.5, and 7.0.0).
With the next release, the docs.7x.version in the pom.xml of the docs/publish module will be updated for the new 7.x version, together with updating the Download page and the News section. Once this is merged to master, Github will update the website again, including the docs.
All the best,Ondro Mihalyi
Director, Jakarta EE expert
OmniFish - Jakarta EE Consulting & Support | www.omnifish.ee
Omnifish OÜ, Narva mnt 5, 10117 Tallinn, Estonia | VAT: EE102487932
On Thu, Jan 19, 2023 at 12:40 PM Hiroki Sawamura (Fujitsu) <sawamura.hiroki@xxxxxxxxxxx> wrote:
_______________________________________________Hi,
the target switching parameter has been added:
- jobs executed with NO_PUBLISH:
- 7.0.0 : https://ci.eclipse.org/glassfish/view/all/job/glassfish-docs-publish/818/
- 6.2.5 : https://ci.eclipse.org/glassfish/view/all/job/glassfish-docs-publish/819/
I made a minimal revision, but perhaps another pom fix is needed to prevent unintentional pushing to gh-pages. (we can recover it by rerunning, so it might not be a problem, though.)
Hiroki
From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Ondro Mihalyi
Sent: Thursday, January 19, 2023 4:38 PM
To: david.matejcek@xxxxxxxxxxx; glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] GlassFish 6 & 7 docs artifacts missing in Maven Central
I’m not a GlassFish committer (yet) but I agree with David - it’s enough to just make the change to the job and ask on the mailing list to review it before running it. Although only committers will be able to review it, it should be enough for now.
Ondro
On Wed, 18 Jan 2023 at 10:49, David Matejcek <david.matejcek@xxxxxxxxxxx> wrote:
Hi,
one option is to create some, but I don't think it is worth of it.
Jenkins saves changes in configuration and they can be compared or reverted, I believe it is enough.
Seems there is also a build parameter for preview.
David.
On 18. 01. 23 10:42, Hiroki Sawamura (Fujitsu) wrote:
Hi,
Perhaps the following Jenkins jobs need to be improved (it runs regularly, but oddly enough only accepts 5.1.0):
https://ci.eclipse.org/glassfish/view/all/job/glassfish-docs-publish/
I suppose I could work on it, but would like to make the changes reviewable. Is there a suitable repository somewhere?
Kind Regards,
Hiroki
From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Ondro Mihalyi
Sent: Tuesday, January 17, 2023 8:13 AM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: [glassfish-dev] GlassFish 6 & 7 docs artifacts missing in Maven Central
Hi,
While updating glassfish.org with info about GlassFish 7 release, I discovered that the Documentation page is also not up to date with the GlassFish 7 version, and not even with the GlassFish 6 version. For example, the docs for the "current" release show docs for GlassFish 5.1: https://glassfish.org/docs/
I've created a PR to fix this, but this requires that the org.glassfish.docs:distribution artifact version 6.2.5 and 7.0.0 are in a Maven repo, either in Maven Central or in a Jakarta repo, which is accessible from GlassFish Jenkins instance.
But the org.glassfish.docs:distribution artifact for version 6.2.5 and 7.0.0 aren't in Maven Central. The latest version in Maven Central is 5.1.0: https://search.maven.org/artifact/org.glassfish.docs/distribution
Can somebody from the committers deploy the missing versions 6.2.5 and 7.0.0 of the org.glassfish.docs:distribution artifact into Maven Central? The source code of this artifact is in https://github.com/eclipse-ee4j/glassfish/tree/master/docs/distribution. I also suggest adjusting the current release CI jobs to deploy this artifact together with other release artifacts in the future.
All the best,
Ondro Mihalyi
Director, Jakarta EE expert
OmniFish - Jakarta EE Consulting & Support | www.omnifish.ee
Omnifish OÜ, Narva mnt 5, 10117 Tallinn, Estonia | VAT: EE102487932
_______________________________________________glassfish-dev mailing listglassfish-dev@xxxxxxxxxxxTo unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev
--David Matejcek | OmniFishdavid.matejcek@xxxxxxxxxxx | +420 777 601 682_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev
_______________________________________________ glassfish-dev mailing list glassfish-dev@xxxxxxxxxxx To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev
-- David Matejcek | OmniFish david.matejcek@xxxxxxxxxxx | +420 777 601 682