Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] Proposed Process for New Features, release plans post 7 Final
  • From: "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
  • Date: Thu, 8 Dec 2022 22:38:00 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=payara.fish; dmarc=pass action=none header.from=payara.fish; dkim=pass header.d=payara.fish; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h0+8W0Nsz+iRFoGZqGgI0ihYIWNL3UIR5yEiH/VBfWg=; b=femaU00D7YDhhTU2QpnKikIhLocXLknCBebV0FKPudYCWyiCwS1dkflBhxBlu4MhL0WKclJQujo7QcG/k4sdSk7GlivPIFUm0aEcjabmLDBz9G0Qyw0KqOCxTP77fNuUA4kxu4XOP91HudSu+lPGlYA1J+syNpnCQNK1l33lhe0kVzuMObLndNu29EhhC26a6KjOLExn8gDZ8byEi3eJ3tQYzW23C3xqxm1E29aAYzLmkdXhlqSCgEuHFffnSmzFIFPcwdMuraV4hfzlLC/9ZorpjKdXWEP5ldGsTJKKyfjTp3qTyh1PApQgDHEgRfjK9oeMfRMbZ2wSiu0lg0LeSA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JhACJTuR3Dj4tVTC6oAift8s/kK64Zo2n3ulr6uSBM1rDdqq+I/qbx1S1jrpChvKhMbVbnk3YjM9qPGOjMsDqxN280NKs6HPlEHD5vn21E80vHpDe5xYcgVwaBeUfxmHXhFhp+BGymM5aNBYF8/HzifQg145IK7730Pmij+0oHBkhPf4DOPlEqLrPgsGmmgO/Eje2DgOfEciaCrGiVODFc9l6drRAR2FGV1U5PjRNfMcbrJ8PQKubN5wEKpX/2WLvEgxYtoyIbgIi4IjOysySKl5vBV9bhSGzCF/ydgdjhDfl6Jj9+zSFtNkvOkZQPkckhJQ0SjvI82LTlraRrRpIw==
  • Delivered-to: glassfish-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/glassfish-dev/>
  • List-help: <mailto:glassfish-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/glassfish-dev>, <mailto:glassfish-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/glassfish-dev>, <mailto:glassfish-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AdkLNcHpewPond6GSuuUoB27DTWNywADIIIAAAP6Kp8AAHx1AAAAJZ17
  • Thread-topic: [glassfish-dev] Proposed Process for New Features, release plans post 7 Final
Please suggest a different process for creating release plans and involving other stakeholders if you feel my proposal is overbearing?

IMHO reviewing completed PRs for a new feature is not a good process. 


From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> on behalf of arjan tijms <arjan.tijms@xxxxxxxxx>
Sent: Thursday, December 8, 2022 10:26:30 PM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Proposed Process for New Features, release plans post 7 Final
 
Hi,

On Thu, Dec 8, 2022 at 11:13 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:
I see you disagree with the proposal?

Not necessarily. The comment above was primarily about whether the MP feature additions had suitable reviews or not.

Regarding the proposal, obviously it's good to discuss things where needed, but keep in mind that a discussion needs at least two parties. Seeing that the response to requests for reviews is lackluster at least, I'm not holding my breath really. That being said, it's probably good to at least start discussions indeed.

I do think we can do this without an overbearing process.

Kind regards,
Arjan Tijms

 
From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> on behalf of arjan tijms <arjan.tijms@xxxxxxxxx>
Sent: Thursday, December 8, 2022 8:18:42 PM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Proposed Process for New Features, release plans post 7 Final
 
Hi,

On Thu, Dec 8, 2022 at 7:53 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:


Rationale: It has been raised to me as project lead (Note: not by Payara committers) that the incorporation of MicroProfile capabilities without planning, discussion and without suitable review has been problematic for some.


The PR to add MicroProfile config support had been open for 115 days. That should, IMHO, be enough time for anyone who may think it's problematic to say something about it. At least something from Oracle took a look at it, and then of course two people from OmniFish. The contribution was from an external person. In open source we should be happy with contributions, and don't reject them simply because we had not put them on a plan a year ago (open source generally doesn't work like that).

The PR to add MicroProfile jwt support was open for less time, but committers from multiple organizations were requested to review, including Payara. It was their choice however to not respond. Given the nature of open source and version control people can raise concerns and ask for a revert after a PR has been merged, but this too did not happen. Besides OmniFish, an independent GlassFish committer looked at the PR as well.

Altogether it seems to me the reviews have been suitable.

Kind regards,
Arjan Tijms
 
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev

Back to the top