On Thu, Dec 8, 2022 at 7:53 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:
Rationale: It has been raised to me as project lead (Note: not by Payara committers) that the incorporation of MicroProfile capabilities without planning, discussion and without suitable review has been problematic for some.
The PR to add MicroProfile config support had been open for 115 days. That should, IMHO, be enough time for anyone who may think it's problematic to say something about it. At least something from Oracle took a look at it, and then of course two people from OmniFish. The contribution was from an external person. In open source we should be happy with contributions, and don't reject them simply because we had not put them on a plan a year ago (open source generally doesn't work like that).
The PR to add MicroProfile jwt support was open for less time, but committers from multiple organizations were requested to review, including Payara. It was their choice however to not respond. Given the nature of open source and version control people can raise concerns and ask for a revert after a PR has been merged, but this too did not happen. Besides OmniFish, an independent GlassFish committer looked at the PR as well.
Altogether it seems to me the reviews have been suitable.
Kind regards,
Arjan Tijms