| Re: [glassfish-dev] PR Approval in the GlassFish project |
|
Good point. I would assume independent committers are from a separate organization. I don’t want to hinder speed so maybe 1 working day is enough for a single organisation to merge. PRs can always be reverted if people object. Maybe also this rule should also only apply to master rather than feature branches so that feature development can also proceed in the core GitHub repo rather than on forks.
Steve From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx>
On Behalf Of Ed Bratt How about a time allowance if you don't get a review from someone in a separate organization? 48 hours? I presume all committers without a named employer are considered separate organizations. Correct? This will apply to all repositories in Eclipse Glassfish project? -- Ed Bratt -------- Original message -------- From: "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
Date: 2/25/20 2:42 AM (GMT-08:00) To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: [glassfish-dev] PR Approval in the GlassFish project
Hi, As we are starting the development on GlassFish 6.0 I would like to agree how we gain approval of PRs. As a balance between speed and oversight I suggest this rule. “A PR can be merged by any committer (including the creator) after 1 approved review by another committer from a different organisation.” Thoughts? If everybody is OK I will add to the Contributing doc. If there are other suggestions please reply with an alternate suggestion and we can put to the vote. Thanks Steve |