[geomesa-dev] datastore api contract

[Jody Garnett <jody.garnett@xxxxxxxxx>]

So we kind of owe you a pull request :) We packaged up GeoMesa for our last suite release and fixed a couple datastore api bugs that prevented other datastores from working correctly when GeoMesa was installed.

Here are the three fixes:

• https://github.com/boundlessgeo/geomesa/commit/422f2421e8def856c8ad4d0256f6fc4f797069d5
  
• https://github.com/boundlessgeo/geomesa/commit/2e1efb409e3ca0dbc7cce37072d72cdb1fddf1a4
  
• https://github.com/boundlessgeo/geomesa/commit/5d2803c49444651b29887ac8f5f2d7611551569f 

The above commits focus on:

• AccumuloDataStoreFactory.scala
  
• GeoMesaCoverageFormat.scala
  
• CoverageFormat.scala
  

The key take away is checking the URL that is passed in is appropriate (so we do not pretend to accept shapefile or geotiff references):

override def accepts(input: AnyRef) = testURL(input)
override def accepts(source: AnyRef, hints: Hints) = testURL(source)
private def testURL(source: AnyRef) = source match{
  case str: String => str.startsWith("accumulo://")
  case _ => false    
  }

While Tom has signed the correct contributor agreement (for the above snippet) - I expect we come up with a more aesthetically pleasing solution on the dev list.

Tyler (if you are on here) you may have a cleaner branch to use as a starting point?