Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [faces-dev] Planning intermediate 4.1 release
Yes, no issue with the deprecations, we need to be careful with the timing of removals.

My main concern with https://github.com/jakartaee/faces/issues/1725 is whether we can remove this in a minor 4.1 release. According to the comment from Ed, it had to wait until a Major release for removal. Meetings minutes where this was discussed on the platform call: https://jakartaee.github.io/jakartaee-platform/minutes/2022/2022-11-15.html
 
For https://github.com/jakartaee/faces/issues/1707 we just need to ensure it stays deprecated in 5.0 (EE11) and isn't removed.

Regards,

Paul Nicolucci

On Mon, Sep 4, 2023 at 11:16 AM Thomas Andraschko via faces-dev <faces-dev@xxxxxxxxxxx> wrote:
Then lets please keep the deprecation in 4.1, we can then remove in 6.0.

Am Mo., 4. Sept. 2023 um 14:06 Uhr schrieb Arjan Tijms via faces-dev <faces-dev@xxxxxxxxxxx>:
Hi,

At least deprecations themselves can be done in any version. It's the actual removal of them that Paul has concerns about.

Kind regards,
Arjan Tijms

On Sat, 2 Sept 2023 at 16:18, Bauke Scholtz via faces-dev <faces-dev@xxxxxxxxxxx> wrote:
Ok as far as I see there are 2 options:

1. Rollback code deprecations/removals from 4.1 branch so it can be released.
2. Skip 4.1 and move/merge all 4.1 into 5.0.

Cheers, B


On Tue, Aug 29, 2023 at 3:07 PM Paul Nicolucci via faces-dev <faces-dev@xxxxxxxxxxx> wrote:
Hi,

I wanted to bring up a couple of concerns with two issues already completed in 4.1:

1) https://github.com/jakartaee/faces/issues/1725, this is to address the following tck challenge: https://github.com/jakartaee/faces/issues/1714 note that there is a comment from Ed Burns that we can't remove this until a major version release, 5.0: https://github.com/jakartaee/faces/issues/1714#issuecomment-1315613269

2) https://github.com/jakartaee/faces/issues/1707, it is fine to deprecate in 4.1 but we cannot remove it in 5.0 (unless some exception is granted) it has to stay deprecated in 5.0 since 4.1 won't be part of any EE platform. See this discussion for further details: https://www.eclipse.org/lists/faces-dev/threads.html#00316 (Discuss Faces 4.1 deprecations with plans to remove in Faces 5.0). I know we've already discussed this on the mailing list just putting it here to be complete.

Thanks,

Paul Nicolucci

On Tue, Aug 29, 2023 at 9:45 AM Thomas Andraschko via faces-dev <faces-dev@xxxxxxxxxxx> wrote:
IMO i dont see a big benefit if we dont resolve some further tickets:

https://github.com/jakartaee/faces/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.1

we have 9 closed, 13 open.

Am Di., 29. Aug. 2023 um 15:38 Uhr schrieb Arjan Tijms <arjan.tijms@xxxxxxxxxxx>:
Hi,

On Tue, 29 Aug 2023 at 13:29, Bauke Scholtz <balusc@xxxxxxxxx> wrote:
If it's too much work to release a minor release (I had no idea) we can always skip 4.1 and move all the work to 5.0.

It's not so much work really, but if we want to do it, we should not wait for much longer. Ideally the 4.1 release vote etc should already have started.

If we can start the release based on the current 4.1 branch that would be great. The tracker doesn't seem to have any PRs for 4.1:

Arjan Tijms

_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev
_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev
_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev
_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev
_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev

Back to the top