Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [faces-dev] Discuss Faces 4.1 deprecations with plans to remove in Faces 5.0
Hi,

It's only removed in a feature branch: https://github.com/eclipse-ee4j/mojarra/pull/5292

Cheers, Bauke


On Wed, Aug 2, 2023 at 11:27 AM Paul Nicolucci <pnicolucci@xxxxxxxxx> wrote:
Hey Bauke,

The deprecation in 4.1 is fine, we just need to keep it deprecated in 5.0 unless an exception is granted. I looked at the main branch and still see the classes:


Was it actually removed in a branch that I missed for 5.0?

Regards,

Paul Nicolucci

On Wed, Aug 2, 2023 at 10:34 AM Bauke Scholtz <balusc@xxxxxxxxx> wrote:
Hi,

https://github.com/jakartaee/faces/issues/1707 is the only one. Note that this concerns already-dead code. It would be very surprising if anyone was actually using it in Faces 4.0.

Cheers, Bauke

On Wed, Aug 2, 2023 at 8:50 AM Paul Nicolucci <pnicolucci@xxxxxxxxx> wrote:
Hey Bauke,

Is there currently anything that would need to be reverted for 5.0? IMO we should revert removals in 5.0 that would just be deprecated in 4.1 until some sort of exception is potentially granted.

Regards,
Paul Nicolucci

On Tue, Aug 1, 2023 at 8:04 AM Bauke Scholtz <balusc@xxxxxxxxx> wrote:
Hi Paul,

I was indeed not aware. Thanks for the heads up. I'll keep it in mind for the next time.

Arjan however has a point. I'll leave up to Arjan whether to keep it or to revert it.

Cheers, Bauke

On Mon, Jul 31, 2023 at 3:36 PM Arjan Tijms via faces-dev <faces-dev@xxxxxxxxxxx> wrote:
Hi,

Perhaps the key sentence here is:

"This is to discourage a Component specification quickly doing two or more back-to-back releases to quickly remove a feature."

So the spirit of the rule is to quickly remove a feature by doing "sneaky" back-to-back releases, say 4.1 in Jul, and then 5.0 in August. But with something like a year to go before 5.0 is released, is that the case here?

I realize it does depend on how fast we could potentially get 4.1 out of the door, and if the spec committee and/or PMC is willing to grant an exception here. Also note that Faces has become a rather small community, with essentially 4 stakeholders; Mojarra, MyFaces, PrimeFaces and OmniFaces (and the stakeholders overlap even). If all are in agreement over the deprecation and removal it should hopefully count a little.

Kind regards,
Arjan Tijms





On Mon, 31 Jul 2023 at 19:37, Paul Nicolucci via faces-dev <faces-dev@xxxxxxxxxxx> wrote:
Hi, I was looking over the following issues:

1) https://github.com/jakartaee/faces/issues/1707 specifically the comment here: https://github.com/jakartaee/faces/issues/1707#issuecomment-1646638275
2) https://github.com/jakartaee/faces/issues/1830

From a Faces perspective, it does not look as though we can deprecate something in 4.1 and then plan to remove it in 5.0 because 4.1 is not part of the Platform specification or its profiles.

There was recently an email on the spec mailing list: https://www.eclipse.org/lists/jakarta.ee-spec/msg03023.html. The important part of the linked doc relating
to the above issues is:

"This process covers the Platform specification, its profiles, and the Component specifications that constitute them. Because of the capability for Component specifications to potentially release at a quicker cadence to the Platform and its profiles, it should be clarified that the Platform specification and its profiles are not allowed to “jump” a Component specification release to introduce breaking changes without first deprecating the feature/behaviour in the Platform specification and its profiles. This is to discourage a Component specification quickly doing two or more back-to-back releases to quickly remove a feature. See the Platform Feature section for further details."

For issue #1830 that means we can only remove something in 5.0 (EE11) that was previously deprecated in 4.0 (EE10) but not in 4.1.

I wanted to bring this up for discussion on the mailing list to ensure the entire Faces team was aware.

Regards,

Paul Nicolucci

_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev
_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev

Back to the top