Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [faces-dev] Remove deprecated methods from jakarta.faces.application.StateManager
TBH i dont know, he is already away since 2018 :/

arjan tijms <arjan.tijms@xxxxxxxxx> schrieb am Do., 2. Sept. 2021, 15:14:
Hi

On Thursday, September 2, 2021, Thomas Andraschko <tandraschko@xxxxxxxxxx> wrote:
Hi

Let me please check it in MF in 2 weeks, Leo maintained this code and im in holiday right now


Sure, I found it relatively easy to remove the deprecated methods in Mojarra. Most weren’t used, and only a few places needed to use the non-deprecated alternatives instead (which they should have used by now anyway).

Btw, what’s Leo doing these days? Any idea? 

arjan tijms <arjan.tijms@xxxxxxxxx> schrieb am Do., 2. Sept. 2021, 13:38:
Hi,

I just did the PR that removes the deprecated methods and the inner class SerializedView: https://github.com/eclipse-ee4j/mojarra/pull/4959

Kind regards,
Arjan Tijms



On Wed, Sep 1, 2021 at 9:17 PM arjan tijms <arjan.tijms@xxxxxxxxx> wrote:
Hi,

On Wed, Sep 1, 2021 at 5:47 PM David Matějček <dmatej@xxxxxxxxx> wrote:
Hi,

I agree with this idea, btw the SerializedView should die too => then nearly all methods in StateManager will be affected.
I'm curious if someone used that in last years.

Me too. In theory it's not such a bad idea, as it makes the back button work really correctly. Essentially without serialised state on server you only store references, and those references point to the current state. This *may* lead to surprises when you use the back button, expect the previous state, but actually get the current one.

That said, the difference is obscure in many cases and the bizarre amount of overhead rarely if ever worth it (in my experience).

Kind regards,
Arjan Tijms


 

Have a nice day,
David Matějček.


On 01. 09. 21 14:15, arjan tijms wrote:
Hi,

We discussed removing all or most deprecated things from Faces before. One particular class we did not explicitly discuss is jakarta.faces.application.StateManager

For instance:

   * @deprecated this has been replaced by {@link #saveView}. The default implementation calls <code>saveView</code> and

     * inspects the return. If the return is an <code>Object []</code>, it casts the result to an <code>Object []</code>

     * wrapping the first and second elements in an instance of {@link SerializedView}, which it then returns. Otherwise, it

     * returns <code>null</code>

     *

     */

    @Deprecated

    public SerializedView saveSerializedView(FacesContext context) {


If nobody objects I like to remove these as well.

Thoughts?

Kind regards,
Arjan Tijms



_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev


_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev

Back to the top