Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [faces-dev] Utilising HttpServletMapping in implementation and Portlets
In general it would be great to introduce it but then we have to think about what happens with ExternalContext and Porlet Integration in future.
Its not nice when we have a API (ExternalContext) for Portlet and Servlet and then directly Import servlet stuff.

Maybe we should ask NeilNeil Griffin to chime in.
Not sure he is on this mailing list.

arjan tijms <arjan.tijms@xxxxxxxxx> schrieb am Mo., 30. Aug. 2021, 20:41:
Manfred Riem wrote on Mon 30 Aug 20:38:
> +1 -- All for simplifying any Faces API

Thanks! So I'm thinking about starting with a FacesContext.getHttpServletRequest(), AND/OR ExternalContext.getHttpServletRequest().

For the AND case, specify that FacesContext gets HttpServletRequest from ExternalContext, so Portlet integrators still only have to provide an ExternalContext implementation. They do have to return an HttpServletRequest implementation then.

Kind regards,
Arjan








On Mon, Aug 30, 2021 at 6:56 PM arjan tijms <arjan.tijms@xxxxxxxxx> wrote:
Hi,

For Mojarra we have an open TODO to utilize the HttpServletMapping from Servlet:


However, as usual Portlets prevent direct usage.

Now we could move getHttpServletMapping() to ExternalContext, but the type it returns is in Servlet too. Wrapping that again in Faces specific types is a little against making the code simpler. Things will get more complicated and tedious again.

Maybe it's time to move to supporting HttpServletRequest only and ask whatever technology that integrates with Faces to supply an HttpServletRequest to Faces, whether it's actually Servlet or not?

Thoughts?

Kind regards,
Arjan
_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev

Back to the top