| Re: [epsilon-dev] Breaking change in EvlContext API in snapshots? |
Hi all,This makes sense, thank you. What do you mean with "sol code", BTW?Cheers,AntonioHi everyone,I would say that a move to 2.0 is beneficial. As part of Sina's and my own work, I think a lot of the implementation would benefit from moving a substantial amount of the core code from the sol plugins to common/base plugins. That way the project structure would more closely resemble the Epsilon languages hierarchies.Cheers,_______________________________________________On Sun, Oct 7, 2018 at 7:03 AM Dimitris Kolovos <dimitris.kolovos@xxxxxxxxxx> wrote:Hi everyone,
I agree with Sina's assessment that this was mistyped to start with.
I'm not aware of a good way to signal a forthcoming change of return
type in Java so it sounds like API breakage is due here. If there are
several other cases where we've had to change API (Eclipse's API Tools
[1] may be useful for assessing this) we may consider bumping up to
2.0 instead of 1.6 (which should now be relatively pain-free [2]) for
our next release.
Cheers,
Dimitris
[1] http://help.eclipse.org/photon/index.jsp?topic=%2Forg.eclipse.pde.doc.user%2Ftasks%2Fapi_tooling_setup.htm
[2] https://git.eclipse.org/c/epsilon/org.eclipse.epsilon.git/tree/bumpversion.xml
On 6 October 2018 at 21:49, Sina Madani <sinadoom@xxxxxxxxxxxxxx> wrote:
> Hi Antonio,
>
>
>
> Thank you for bringing this breaking change to our attention. This change
> was discussed numerous times and approved. Furthermore, I believe the return
> type was mis-specified to begin with because duplicate unsatisfied
> constraints should not be in the results (which can happen from satisfies
> operation calls under certain conditions, for example) and the ordering of
> these is arbitrary.
>
>
>
> I know that this change has caused another issue with the Validation view
> not showing results as it expected a List, but this has been fixed also. I
> am not aware of any other public API changes of this kind. If returning a
> Set is a problem, we could change it back to a List when calling the
> getUnsatisfiedConstraints() method and keep it as a Set internally.
>
>
>
> Please let me know if there is anything else I can do to help.
>
>
>
> Thanks,
>
> Sina
>
>
>
> From: Antonio Garcia-Dominguez
> Sent: 06 October 2018 16:44
> To: Epislon Project developer discussions
> Subject: [epsilon-dev] Breaking change in EvlContext API in snapshots?
>
>
>
> Hi all,
>
>
>
> One warning: I have noticed that EvlContext#getUnsatisfiedConstraints() is
> returning a Set instead of an ArrayList in the 1.6.0 interim releases since
> this commit:
>
>
>
> --
>
> commit 6b1e634f08d683c0ab09a5c6014db486edf59967
>
> Author: Sina Madani <sinadoom@xxxxxxxxx>
>
> Date: Fri Mar 30 12:54:37 2018 +0100
>
>
>
> Initial commit of Parallel EVL.
>
> --
>
>
>
> This was breaking ecore2thrift. We shouldn't be changing the public API
> unless we have a very good reason to do so ;-). We shouldn't be returning an
> ArrayList, but rather a List, of course, but we have to think about other
> people who may be integrating Epsilon into their solutions.
>
>
>
> Have we changed any other return types in previously existing public Epsilon
> APIs since 1.5.0?
>
>
>
> Cheers,
>
> Antonio
>
>
>
> --
>
> Antonio Garcia-Dominguez
>
>
>
>
> _______________________________________________
> epsilon-dev mailing list
> epsilon-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/epsilon-dev
--
Dimitris Kolovos
Professor of Software Engineering
Department of Computer Science
University of York
http://www.cs.york.ac.uk/~dkolovos
EMAIL DISCLAIMER http://www.york.ac.uk/docs/disclaimer/email.htm
_______________________________________________
epsilon-dev mailing list
epsilon-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/epsilon-dev
epsilon-dev mailing list
epsilon-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/epsilon-dev--_______________________________________________Antonio Garcia-Dominguez
epsilon-dev mailing list
epsilon-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/epsilon-dev