| Re: [ee4j-pmc] Jakarta EE releases in Maven Central |
Automatic-Module-Name: java.annotation
Hi,
On 11/2/18 3:04 PM, Kevin Sutter wrote:
> My vote is to leave it as is... If we attempt to clean up Maven, it
> will just confuse people and possible get worse... Let's just assume the
> reviews will go through with flying colors... :-)
I believe the voting should happen based on knowing what is wrong or at
least not completely correct in these jars and what possible impact of
those mistakes can be. I believe some of the issues I can see are minor
things and everybody can live with them eventually but I don't feel to
be competent to do such decision especially when it comes to wrong
license file or possibly copyrights - IANAL and prefer to stay on the
safe side, so here is what I spotted:
jakarta.annotation-api has following entries in the manifest:
Specification-Vendor: Oracle Corporation
Implementation-Vendor-Id: org.glassfish
Implementation-Vendor: Eclipse Foundation
-> it was decided that the recommendation for APIs jars is to have
spec-vendor set to eclipse-project-name and impl related entries removed
meta-inf/license.txt contains wrong content (is: cddl, should be epl)
javadoc has possibly wrong copyright in the footer + link to
non-existing license-terms:
<![CDATA[Copyright © 1999-2017,
<a href="" href="http://www.oracle.com" rel="noreferrer" target="_blank">http://www.oracle.com">Oracle</a>
and/or its affiliates. All Rights Reserved.
Use is subject to
<a href=""
target="_top">license terms</a>.
]]>
jakarta.ejb-api - manifest:
Specification-Vendor: Oracle Corporation
javadoc has possibly wrong copyright in the footer + link to
non-existing license-terms:
<![CDATA[Copyright © 1996-2013,
<a href="" href="http://www.oracle.com" rel="noreferrer" target="_blank">http://www.oracle.com">Oracle</a>
and/or its affiliates. All Rights Reserved.
Use is subject to
<a href=""
target="_top">license terms</a>.
]]>
jakarta.persistence-api:
license file is in the root of the jar in html format, not under
META-INF/license.md but the text it contains is correct (EPL2/EDL1)
obsolete about/readme html files in the root of the jar
manifest:
OSGi version of API packages it exports is '2.2.99', should be '2.2.1'
Specification-Vendor: Oracle Corporation
javadoc says: "Copyright © 2017–2018 Eclipse Foundation. All rights
reserved." and that is correct I hope.
thanks,
--lukas
>
>
> ---------------------------------------------------
> Kevin Sutter
> STSM, MicroProfile and Java EE architect
> e-mail: sutter@xxxxxxxxxx Twitter: @kwsutter
> phone: tl-553-3620 (office), 507-253-3620 (office)
> LinkedIn: https://www.linkedin.com/in/kevinwsutter
>
>
>
> From: Dmitry Kornilov <dmitry.kornilov@xxxxxxxxxx>
> To: EE4J PMC Discussions <ee4j-pmc@xxxxxxxxxxx>
> Date: 11/02/2018 08:48 AM
> Subject: Re: [ee4j-pmc] Jakarta EE releases in Maven Central
> Sent by: ee4j-pmc-bounces@xxxxxxxxxxx
> ------------------------------------------------------------------------
>
>
>
> It’s even worse. Today 3 artifacts hit the Maven Central:
>
> jakarta.persistence jakarta.persistence-api 2.2.1 | (1) 02-Nov-2018
> jakarta.ejb jakarta.ejb-api 3.2.3 | (1) 01-Nov-2018
> jakarta.annotation jakarta.annotation-api 1.3.3 | (1) 29-Oct-2018
>
> It was done by mistake. We understand the process and know that public
> releases cannot be done without passing the release review. Wayne, how
> shall we deal with this situation?
>
> Thanks,
> Dmitry
>
> On 2 Nov 2018, at 14:15, Ivar Grimstad <_ivar.grimstad@gmail.com_
> <mailto:ivar.grimstad@xxxxxxxxx>> wrote:
>
> I have added this item to the PMC meeting on Tuesday.
>
> Ivar
>
> On Fri, Nov 2, 2018 at 2:12 PM Kevin Sutter <_sutter@xxxxxx.com_
> <mailto:sutter@xxxxxxxxxx>> wrote:
> You are correct, Christian. The Eclipse Release Review should be
> successful before the artifacts are published to Maven Central.
>
> I'm going to chalk this up to a new process. Everybody has been pushing
> to complete this Glassfish release and the process may not be well
> understood by everybody. (Although the EclipseLink team should know the
> process...)
>
> ---------------------------------------------------
> Kevin Sutter
> STSM, MicroProfile and Java EE architect
> e-mail: _sutter@xxxxxx.com_ <mailto:sutter@xxxxxxxxxx> Twitter:
> @kwsutter
> phone: tl-553-3620 (office), _507-253-3620_
> <tel:%28507%29%20253-3620>(office)
> LinkedIn: _https://www.linkedin.com/in/kevinwsutter_
>
>
>
> From: Christian Kaltepoth <_christian@kaltepoth.de_
> <mailto:christian@xxxxxxxxxxxx>>
> To: EE4J PMC Discussions <_ee4j-pmc@eclipse.org_
> <mailto:ee4j-pmc@xxxxxxxxxxx>>
> Date: 11/02/2018 07:55 AM
> Subject: [ee4j-pmc] Jakarta EE releases in Maven Central
> Sent by: _ee4j-pmc-bounces@eclipse.org_
> <mailto:ee4j-pmc-bounces@xxxxxxxxxxx>
> ------------------------------------------------------------------------
>
>
>
> Dear PMC,
>
> I'm a bit confused. It looks like more and more Jakarta EE releases are
> available in Maven Central:
>
> EJB: _https://search.maven.org/search?q=g:jakarta.ejb_
> JPA: _https://search.maven.org/search?q=g:jakarta.persistence_
>
> But AFAIK there were no Release Reviews for these releases. My
> impression was that releases are first pushed to the staging repository
> and then a corresponding Release Review is created. And only if the
> Release Review is successful, the artifacts a pushed to Maven Central.
>
> Is that correct? Or am I missing some part of the process here?
>
> Best regards
>
> Christian
>
>
> --
> Christian Kaltepoth
> Blog: _http://blog.kaltepoth.de/_
> Twitter: _http://twitter.com/chkal_
> GitHub: _https://github.com/chkal_
> _______________________________________________
> ee4j-pmc mailing list_
> __ee4j-pmc@eclipse.org_ <mailto:ee4j-pmc@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit_
> __https://www.eclipse.org/mailman/listinfo/ee4j-pmc_
>
>
>
> _______________________________________________
> ee4j-pmc mailing list_
> __ee4j-pmc@eclipse.org_ <mailto:ee4j-pmc@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit_
> __https://www.eclipse.org/mailman/listinfo/ee4j-pmc_
> --
>
> Java Champion, JCP EC/EG Member, EE4J PMC, Jakarta EE WG Member, JUG Leader
>
> _______________________________________________
> ee4j-pmc mailing list_
> __ee4j-pmc@eclipse.org_ <mailto:ee4j-pmc@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://www.eclipse.org/mailman/listinfo/ee4j-pmc
> _______________________________________________
> ee4j-pmc mailing list
> ee4j-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://www.eclipse.org/mailman/listinfo/ee4j-pmc
>
>
>
>
>
> _______________________________________________
> ee4j-pmc mailing list
> ee4j-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/ee4j-pmc
>
_______________________________________________
ee4j-pmc mailing list
ee4j-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ee4j-pmc