| Re: [eclipselink-dev] Bug-248491 |
Hello Gordon,I don't require try-catch block. I will remove it and yes, I tested for IllegalArgumentException.
I will update the patch with the suggested changes.
Darani Gordon Yorke wrote:
Hello Darani,The setProperty Method - why are you using a try catch block? The specification requires an IllegalArgumentException if the property value is invalid, have you verified this occurs? You have changed clear() to detach but have not changed the CascadeType or the code that cascades the detach.--Gordon Darani Yallapragada wrote:Hello :A patch for Bug-248491 has been uploaded. Please do take a look and let me know if any changes are needed.https://bugs.eclipse.org/bugs/show_bug.cgi?id=248491 Thank You Regards Darani _______________________________________________ eclipselink-dev mailing list eclipselink-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/eclipselink-dev_______________________________________________ eclipselink-dev mailing list eclipselink-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/eclipselink-dev