[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [eclipselink-dev] Renaming some classes (migration cleanup)
|
Thanks Michael,
I thought I had found all the references in examples, but I guess I missed some.
I will log a bug to have the examples and dbws put into the build.
I still need to update the wiki examples and docs, hopefully today.
-----Original Message-----
From: MICHAEL.OBRIEN@xxxxxxxxxx
Sent: Tuesday, June 17, 2008 10:32 PM
To: Dev mailing list for Eclipse Persistence Services
Subject: RE: [eclipselink-dev] Renaming some classes (migration cleanup)
James,
Thanks for fixing the packages in.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=229763
1) The following bugs were checked in to fix some minor compile issues in examples and dbws due to moved/renamed classes in 229763.
They occurred in projects that are not part of the core|jpa build and lrg's so are easy to miss without viewing them in eclipse.
For myself, I find it good to import all the projects from the trunk into my workspace - compile problems then show up immediately in eclipse in 4-16 min depending on whether you have a single/dual/quad core.
Fixed
https://bugs.eclipse.org/bugs/show_bug.cgi?id=237528
Fixed
https://bugs.eclipse.org/bugs/show_bug.cgi?id=237531
Should be unrelated
https://bugs.eclipse.org/bugs/show_bug.cgi?id=237568
2) ELUG/WIKI Changes
Here is a doc bug as requested that will need to be updated to reflect your changes.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=229763
- Moved DescriptorCustomizer and SessionCustomizer from internal package to config.
- Added DescriptorCustomizer and SessionCustomizer subclasses in org.persistence.sessions.factories (for potential migration of broad imports)
thank you
/michael
-----Original Message-----
From: JAMES.SUTHERLAND@xxxxxxxxxx
Sent: Monday, June 16, 2008 3:07 PM
To: Dev mailing list for Eclipse Persistence Services
Subject: RE: [eclipselink-dev] Renaming some classes (migration cleanup)
I am ready to commit these changes.
Please be careful in merging any outstanding changes to the moved classes.
I used move in SVN, so hopefully it will work ok, but from my ADE paranoia, I expect possible issues, but I will refresh and try to ensure I fix any.
Please let me know if you can think of any other places this rename will effect. I will update the docs and examples on the Wiki.
I will test the package renamer in its entirety, as we have not tested it in a while.
-----Original Message-----
From: DOUGLAS.CLARKE@xxxxxxxxxx
Sent: Wednesday, June 11, 2008 11:25 AM
To: Dev mailing list for Eclipse Persistence Services
Subject: RE: [eclipselink-dev] Renaming some classes (migration cleanup)
I like the proposed changes but agree that the migration scenarios and testing need to be covered.
Doug
-----Original Message-----
From: TOM.WARE@xxxxxxxxxx
Sent: Tuesday, June 10, 2008 3:17 PM
To: Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Renaming some classes (migration cleanup)
My only concern is that the package renamer must continue to work properly.
We chose not to move certain classes from the packages they were in to allow the
package renamer to work more seamlessly.
As you mention, changing packages can affect users that that do things like
importing with "*".
As long as you are testing that the package renamer works for these classes with
both broad and narrow imports, it should be fine.
-Tom
JAMES.SUTHERLAND@xxxxxxxxxx wrote:
> There are some classes that ended up not being renamed in the migration,
> or migrated to the wrong packages. I would like rename these before the
> 1.0 release to avoid having to deprecated things and move them again in
> a future release, or have yet another package renamer in our next release.
>
>
>
> The package renamer will be update to rename these classes/packages.
>
>
>
> Bug numbers, 213028, 221500, 231621, 211263.
>
>
>
> EclipseLinkQueryHints -> QueryHints
>
> EJBQLPlaceHolderQuery -> JPAQuery
>
> (org.eclipse.persistence.internal.sessions.factories) SessionCustomizer,
> DescriptorCustomizer -> org.eclipse.persistence.jpa.config
>
> (org.eclipse.persistence.internal.sessions.factories)
> XMLSessionConfgLoader -> org.eclipse.persistence.sessions.factories
>
> (org.eclipse.persistence.sessions.factories)
> DirectToXMLTypeMappingHelper,
> EclipseLinkObjectPersistenceRuntimeXMLProject,
> MissingDescriptorListener, ObjectPersistence*Project* ->
> (org.eclipse.persistence.internal.sessions.factories)
>
> CMP3Policy -> IdPolicy
>
>
>
> For the Customizers I think I will also put subclasses in the factories
> package, as the package renamer cannot split packages if users used
> broad imports (narrow imports are ok).
>
>
>
> I would also like to rename jpa.config to just config:
>
> - It should follow the same naming convention as annotations (which does
> not have jpa, even through the annotations depend on and are extensions
> of JPA annotations).
>
> - The classes are in the foundation component, not the JPA component,
> and have dependencies from foundation classes.
>
> - Some of the classes in config can be used from non JPA classes.
>
>
>
> Please reply with any thoughts if you have any on this.
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
