Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[ecd-pmc] Committer Election for Kenneth Marut on Eclipse Theia has started

A committer election for Kenneth Marut on project Eclipse Theia (ecd.theia)
was started by Marc Dumais with this criteria:

I hereby nominate Kenneth Marrut for committership in the Eclipse Theia
project.

Ken, working with a couple of his colleagues, is behind the much-improved
Preferences UI Widget, that was merged this spring. Since then he continued
to provide support this component, contributing a couple of follow-up PRs and
a few PRs in other areas, for issues he noticed. During these activities, Ken
has demonstrated he has the will to work with the community, take review
comments constructively and be willing to make changes after discussion. I
believe he will be a good asset to the project.

Please see below for more details about Ken's contributions to the project,
so far:

Merged Pull Requests:
   · Added Preferences UI Widget (#7105)
     o Co-authors: Colin Grant (colin-grant-work) & Nicholas Stenbeck
(NicholasStenbeck)
     o Description: PR was started early February 2020 by Ken's colleague
Nicholas Stenbeck. Then Ken and colleague Colin Grant inherited this effort
in March of 2020 and worked together closely to improve the PR, answering
review comments, until it was approved.  Merged on May 6, 2020.

   · Fix ElectronContextMenuRenderer to use passed in anchor XY values
(#7735)
     o Description: Addresses issue #7722, caused by context menu renderer
being rendered at incorrect anchor location on right-click in Electron only.
Was signed-off additionally by Colin Grant as he helped with some testing and
review.

   · Bugfix/Stringify Task ENUMs for Presentation and PanelKind (#7982)
     o Description: Addresses issue #7956 where ENUM values for PanelKind and
RevealKind were not properly being stringified to their values defined in the
task-schema-updated.ts. This was causing issues when using the
TaskConfigurationManager to create tasks and viewing the corresponding
tasks.json file.

   · Feature/preferences ui tab styling (#7793)
     o Description: Addresses issue (#7768) and introduces some additional UI
improvements to the preferences tabbar. The changes include only showing tab
drop-shadow when scrolled, moving tab on-select highlight to underneath tab,
adds dividing line below tabbar, removing residual ‘focus’ outline on
folders tab.

   · Vsx-extensions-view-styling-improvements (#8086)
     o Co-authors: Colin Grant (colin-grant-work)
     o Description: Introduces styling improvements to vsx-extensions view to
be more inline with VSCode including: sticky header, dividing lines,
max-width body container, image resizing, scrollbar fixes. I started this PR
and received some additional help & refactoring from Colin Grant. He took
over for the merge as I left for vacation.

Submitted Issues:
   · Preference change does not fire an onPreferenceChanged event (#7685)
   · Electron ContextMenuRenderer does not use passed-in anchor values
(#7722)
     o Addressed by #7735 mentioned above
   · TaskConfiguration setter does not properly stringify TaskConfig (#7956)
     o Addressed by #7982 mentioned above
   · Add “tasks” to .theia-workspace file (#8519)
   · File explorer search/filter keyboard behavior is unexpected (#8541)

Other:
   · Review open PR’s by Colin Grant (#8263) and WIP (#8540)
   · Regular attendance of Theia stand-up meetings since beginning of July
2020




Eclipse Theia project committers can click the election link below to vote.

Election:
https://projects.eclipse.org/projects/ecd.theia/elections/election-kenneth-marut-committer-eclipse-theia

Project: https://projects.eclipse.org/projects/ecd.theia



Back to the top