RE: [dtp-dev] Re: generic ddl generator patch

[Lawrence E Dunnell <ledunnel@xxxxxxxxxx>]

The DDL Generation wizard from WTP has
not yet been restored in DTP.  That wizard will allow the user to
set the options.

Larry Dunnell
RAD Data Tools, DB2 Tooling,  Eclipse WTP Project and Eclipse DTP
Project 
IBM DB2 Information Management Software

"Grimmer, Francine" <FG120874@xxxxxxx>

09/08/2006 08:32 AM

To	"DTP development mailing list" <dtp-dev@xxxxxxxxxxx>
cc	Lawrence E Dunnell/Redmond/IBM@IBMUS
Subject	RE: [dtp-dev] Re: generic ddl generator patch

As long as you are looking at
the DDL Generator, I would like to ask about adding methods allowing users
to set the options. Currently there are only methods to getOptions.  This
would allow users to set whether they want to include fully qualified names.
 Again, allowing the tools to use the generic interface and not have
to have a vendor specific DDL generator. Or is this done someplace else
that I am missing?
 
thanks,
-Francine Grimmer

---

From: dtp-dev-bounces@xxxxxxxxxxx
[mailto:dtp-dev-bounces@xxxxxxxxxxx] On Behalf Of Hui.Cao@xxxxxxxxxx
Sent: Thursday, September 07, 2006 7:30 PM
To: Lawrence E Dunnell
Cc: dtp-dev@xxxxxxxxxxx
Subject: [dtp-dev] Re: generic ddl generator patch


Hi Larry, 
        Thanks for your review and I can understand
your concern. The sequence of the script is a well-spotted bug. You're
right, I'll put the Routine and Event DDL in vendor specific DDL generators.
But since Routine and Event are all basic SQL model objects, I think the
option id for them should be defined in the generic EngineeringOptionID,
and the descriptions in the GenericDdlGeneration.properties file as well.
This can ease the vendor specific DDL generator implementation and allow
SQL Dev Tools to treat them in a generic way. 
        Another minor suggstion is to allow GenericDdlGenerator
to be extended by changing some of the private access modifiers to protected.
The reason is DdlGenerator
contains no vendor specific logic, while DDLBuilder does, so we can reuse
the construction logic in GenericDdlGenerator.

Best Regards!

Max ( Hui ) Cao
Sybase, Inc. Shanghai, China

Lawrence E Dunnell <ledunnel@xxxxxxxxxx>

09/07/2006 04:28 AM

To	Hui.Cao@xxxxxxxxxx
cc	dtp-dev@xxxxxxxxxxx
Subject	Re: generic ddl generator patch

Max, 

One of our engineers reviewed the patch and had the following concerns.
 The major issue is whether the DDL is truly generic and of any value
in the generic DDL support.  It seems that the DDL for at least Routines
and Events should only appear in the vendor specific DDL generators and
really is not of much value in the generic generator as it probably will
not execute successfully anyway.  Can you explain what value you think
is derived from having routines and events in the generic DLL generator?

--------------------------------------------------------------------
The code looks good except the sequence of script in GenericDdlScript
should be: 
               scriptVec.addAll(dropTriggerStatements);
               scriptVec.addAll(dropEventStatements);
               scriptVec.addAll(dropRoutineStatements);
               ...
               scriptVec.addAll(createRoutineStatements);
               scriptVec.addAll(createEventStatements);
               scriptVec.addAll(createTriggerStatements);
Because trigger may have the reference to routine/event.

I have a concern about routine/event support in generic ddl generator:
generic ddl generator is for 
sql 92/99 standard. the generated ddl should work for all database which
compatible with sql 92/99. 

As I know, DBMS(s) (Oracle, db2, sql server..) have different syntax for
routine. So the generated script for routine won't work for most of the
database. 

-------------------------------------------------------------------------------------------------------------------------

Larry Dunnell
RAD Data Tools, DB2 Tooling,  Eclipse WTP Project and Eclipse DTP
Project 
IBM DB2 Information Management Software

Notes address: Lawrence E Dunnell/Redmond/IBM@IBMUS
Internet address: ledunnel@xxxxxxxxxx
tel: 206 587 5957
tie line: 277 5957

Hui.Cao@xxxxxxxxxx

09/05/2006 01:11 AM

To	Lawrence E Dunnell/Redmond/IBM@IBMUS, dtp-dev@xxxxxxxxxxx
cc
Subject	generic ddl generator patch

Hi Larry, 
      To support all 4 types of procedural objects: stored
procedure, udf, trigger and event, sql dev tools needs to modify the generic
ddl generator. Basically the attached patch just added "create"
and "drop" support for these sql objects. Can you please have
a review? Thanks in advance! 


Best Regards!

Max ( Hui ) Cao
Sybase, Inc. Shanghai, China [attachment "genericddl-patch.txt"
deleted by Hui Cao/SYBASE]