Have all of the issues running the TCK on Glassfish been resolved, and if so, can a 3.0.2 release of Concurrency be created and promoted?
The Jenkins jobs all look different from when I last looked at them from the 3.0.0 release, but this one appears to have a 3.0.2 build of the TCK from August 9,
https://ci.eclipse.org/cu/job/concurrency_tck_1-build-and-stage/
From:
cu-dev <cu-dev-bounces@xxxxxxxxxxx> on behalf of Scott Marlow <smarlow@xxxxxxxxxx>
Date: Thursday, August 11, 2022 at 1:31 PM
To: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>, glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Cc: cu developer discussions <cu-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cu-dev] [jakartaee-platform-dev] Latest CU results with Eclipse GlassFish
We will test with draft pull request https://github.com/eclipse-ee4j/jakartaee-tck/pull/1111 If the test shows that GlassFish can pass the Concurrency TCK tests
in Web Profile mode, one of the committers can update the PR from draft to `Ready
|
This Message Is From an External Sender
|
|
This message came from outside your organization.
|
|
|
We will test with draft pull request https://github.com/eclipse-ee4j/jakartaee-tck/pull/1111
If the test shows that GlassFish can pass the Concurrency TCK tests in Web Profile mode, one of the committers can update the PR from draft to `Ready for review` and when approved, then merged in.
Then https://ci.eclipse.org/jakartaee-tck/job/10/job/jakarta-concurrency-tck-glassfish-run +
https://ci.eclipse.org/jakartaee-tck/job/10/job/jakarta-concurrency-tck-glassfish-run-jdk17 can be updated to run both the `suite-web.xml` (won't run currently failing test) + `suite-web-group2.xml`
(will run currently failing test in isolation from other tests) separately, at least that is the idea.
Scott
On 8/11/22 11:38 AM, Scott Marlow wrote:
Since no one has spoken up against running the `ee.jakarta.tck.concurrent.spec.ManagedExecutorService.resourcedef.ManagedExecutorDefinitionWebTests.testCopyCompletableFutureEJB` test separately, I think we should try that in our Platform TCK CI environment.
Any volunteers to update https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/glassfish-runner/concurrency-tck/suite-web.xml (+ rename to suite-web-group1.xml) to exclude the `ee.jakarta.tck.concurrent.spec.ManagedExecutorService.resourcedef.ManagedExecutorDefinitionWebTests.testCopyCompletableFutureEJB`
test and add a https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/glassfish-runner/concurrency-tck/suite-web-group2.xml that does run `ee.jakarta.tck.concurrent.spec.ManagedExecutorService.resourcedef.ManagedExecutorDefinitionWebTests.testCopyCompletableFutureEJB`?
Then we just need to invoke the suite-web-group1.xml tests first and then the suite-web-group2.xml tests (perhaps just copy each of these files to suite-web.xml and run Web Profile tests). Or if you have a better way, that is fine also.
Scott
On 8/11/22 8:33 AM, Scott Marlow wrote:
Ed,
Thanks for sending this note.
I find Ondro's comment to be very interesting in that we may have a workaround of running the ee.jakarta.tck.concurrent.spec.ManagedExecutorService.resourcedef.ManagedExecutorDefinitionWebTests.testCopyCompletableFutureEJB test separately so it won't fail.
That sounds like a valid workaround to me. If anyone disagrees please comment on the
issue as to why.
Scott
On 8/10/22 11:17 AM, Ed Bratt wrote:
In the Platform Committer team meeting yesterday, we were discussing the latest updates with Concurrency Utilities and the impact on Eclipse GlassFish 7.
The revised CU TCK (3.0.2) was run against GlassFish 7 (latest snapshot) and there is still one test failure. The issue discription is captured in
GlassFish Issue 24509. GlassFish and TCK teams are currently working to determine if this is an issue that can be resolved in GlassFish.
You can view the latest status via the issue conversation.
Cheers,
-- Ed
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
