Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cu-dev] Javadoc implies a deployment descriptor
  • From: "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
  • Date: Thu, 3 Mar 2022 16:04:58 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=payara.fish; dmarc=pass action=none header.from=payara.fish; dkim=pass header.d=payara.fish; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98ZTQO9swTtviIUYp2Uro/qF0cA7E9R+sZREMq2+8WY=; b=eWM4S4WQeJmUkyP2hPLisTSRtPG32dCQH+GgVfW1WEvaKzmnIDa8mJb9jY8CbgN6mPiIg8iViLNes/gaXPJU7NgRjDdisdOEa6o2Ik9fk8tqm6zAtmefrnNhQ/F2vu1xVNxnQG7CIf9wHotIpxo0whFeNZuib85600jd5mlZwR61EkXb93xTBeyaykTffOij17r2TmuhAIhhRbR7Py9kSoVw5HB9/W1ks24dm/NyGRw2InYk765//A71Ak0/8QgJ05mWQOtBepO2QkGuitVNTmCEvHkGo2dRAMSjPzsnuN8/92e5Dm7QQ6YvVA7S6sHcNAYhByiKp/YVyyTAdhABeA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JySb5uFOZyoiWbirR1VWLKlReXEcc7gtGdcdc3N9RVjWo2XryNy9m1o8+E+ZfSCdMbUWikJCDTEg5gnK94JZO3axeY7FZvPaKSvOfeMVd6s8WXWvk671iJHseHaWfnH+2NUGlWNPOvobGgwbUfNAFc/YuZlGxHmOmoC5Jg6csCBZtjrN8GMtuQh9Z6LZqFY4eiUhdcWtyzntz3JzZVc1Uni+gm2mC5M91rxmwutHFerAlpNnUg0O59aNOahqW1e1gp7gwBsl3WCRQ7SWJFEZQ+LAvh/OfaH1jd05D/dXPHqIzlbAgv2yfjtWfB5gVfcVaYHRrQFPjGoZ0QHM3xwhFQ==
  • Delivered-to: cu-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/cu-dev/>
  • List-help: <mailto:cu-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/cu-dev>, <mailto:cu-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/cu-dev>, <mailto:cu-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHYLxVJlIsjYhbDGkafhanoEaJDcqyt0nJA
  • Thread-topic: [cu-dev] Javadoc implies a deployment descriptor

Cool thanks. I realise I have no idea how these schemas are interlinked!

 

Steve

 

From: cu-dev <cu-dev-bounces@xxxxxxxxxxx> On Behalf Of Nathan Rauh
Sent: 03 March 2022 15:42
To: cu developer discussions <cu-dev@xxxxxxxxxxx>
Subject: Re: [cu-dev] Javadoc implies a deployment descriptor

 

Yes, I agree.

It gets to web.xml indirectly by inclusion in xml/src/jakartaee_10.xsds

which is included by web-common_6_0

which is included by web-app_6_0

 

I did it this way to most closely follow the precedent that was established by existing application-defined resource types such as data-source and connection-factory.  If this isn’t correct, we can move it.

 

A unit test in the platform schema project validates that it can be put in web.xml,

https://github.com/eclipse-ee4j/jakartaee-schemas/pull/29/files#diff-ac91fbdf21b900e6655191f25add2f29c087b75353553674e119093f9f097dcf

 

 

From: cu-dev <cu-dev-bounces@xxxxxxxxxxx> on behalf of "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
Reply-To: cu developer discussions <cu-dev@xxxxxxxxxxx>
Date: Thursday, March 3, 2022 at 9:25 AM
To: cu developer discussions <cu-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cu-dev] Javadoc implies a deployment descriptor

 

Hi Nathan,

 

As Concurrency is in the web profile I think we also needed it added to web.xml. What do you think?

 

Steve

 

From: cu-dev <cu-dev-bounces@xxxxxxxxxxx> On Behalf Of Steve Millidge (Payara)
Sent: 03 March 2022 14:43
To: cu developer discussions <cu-dev@xxxxxxxxxxx>
Subject: Re: [cu-dev] Javadoc implies a deployment descriptor

 

Thanks Nathan I missed that.

 

From: cu-dev <cu-dev-bounces@xxxxxxxxxxx> On Behalf Of Nathan Rauh
Sent: 03 March 2022 14:19
To: cu developer discussions <cu-dev@xxxxxxxxxxx>
Subject: Re: [cu-dev] Javadoc implies a deployment descriptor

 

Steve,

 

It’s already in the platform schema,

https://github.com/eclipse-ee4j/jakartaee-schemas/pull/29/files

I added it last year at the same time we added ManagedExecutorDefinition and the other annotations.

 

Our project TCK doesn’t currently test this because the function is part of the platform schema not the Concurrency spec, and I had been thinking that any testing which gets done for it would need to be in the platform tests.  However, over the past half year or so there seems to be a greater acceptance within the community of moving platform level testing to the individual spec project TCKs (and then deleting the platform tests), so we could potentially do that.

 

 

From: cu-dev <cu-dev-bounces@xxxxxxxxxxx> on behalf of "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
Reply-To: cu developer discussions <cu-dev@xxxxxxxxxxx>
Date: Thursday, March 3, 2022 at 4:03 AM
To: cu developer discussions <cu-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] [cu-dev] Javadoc implies a deployment descriptor

 

Hi,

 

The Javadoc for ManagedExecutorDefinition states a deployment descriptor can be used to create a ManagedExecutor see concurrency-api/ManagedExecutorDefinition.java at master · eclipse-ee4j/concurrency-api · GitHub same for ScheduledExecutorDefinition etc. do we want to remove this from the Javadoc or do we want to try and get this into some platform schema somewhere?

 

I assume the TCK isn’t testing this?

 

Thanks

 

 

 

Steve Millidge

 

 

Back to the top