Re: [che-dev] Conventional commits

[Mario Loriedo <mario.loriedo@xxxxxxxxx>]

On Tue, Jun 15, 2021 at 6:46 PM Sun Tan <sutan@xxxxxxxxxx> wrote:

Hi Mario,

Could we have something in between?

Keep it as it is now: PR check that verifies and encourages the contributors to use it but not block a PR for that ?

If others are ok with it I am ok with that too.

 

Sun Tan

Senior Software Engineer

Eclipse Che - CodeReady Workspaces @ Red Hat

also Paris JUG Leader

Red Hat Paris

sutan@xxxxxxxxxx    
M: +33621024173    

@__sunix_   me  

On Tue, Jun 15, 2021 at 6:42 PM Mario Loriedo <mario.loriedo@xxxxxxxxx> wrote:

As mentioned during yesterday's community call we should have a discussion about conventional commits [1] to decide if we should enforce it or not.

Currently a PR check verifies if commits messages follow the convention. PRs can be merged even if the check fails. But we need to decide if we are going to enforce the convention (block PRs where the check fails, update the contribution guide etc...) or remove the PR check and let contributors free to use any commit message format they like.

What's your thoughts?

[1] https://www.conventionalcommits.org/

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/che-dev

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/che-dev