5 дек. 2019 г., в 15:44, Dmytro Nochevnov <dnochevn@xxxxxxxxxx
<mailto:dnochevn@xxxxxxxxxx>> написал(а):
Hello everyone.
I would also make it clear why it was decided to leave che-bot
comments: Che QE team don't have much resources to answer the
questions like "/Where to find test/product logs?/", "/Which
test(s) failed?/", "/Where to get product images which the
tests were run against?/".
Alternatively, we can prepare a short document about where to
find that information in Jenkins build logs / artifacts, or it
could be put into a short description of Jenkins build.
@Mykola Morhun <mailto:mmorhun@xxxxxxxxxx>:
Will it be possible to quickly (without digging in job
details) see built by Ci image name?
Did you mean an addresses like "maxura/che-server:14540" in PR
check status message on GitHub page?
On Thu, Dec 5, 2019 at 3:29 PM Mykola Morhun
<mmorhun@xxxxxxxxxx <mailto:mmorhun@xxxxxxxxxx>> wrote:
Hello.
Will it be possible to quickly (without digging in job
details) see built by Ci image name?
On Thu, Dec 5, 2019 at 3:19 PM Radim Hopp
<rhopp@xxxxxxxxxx <mailto:rhopp@xxxxxxxxxx>> wrote:
Thanks for raising this topic.
Based on the comments I think it's safe to disable the
bot comments.
I'll wait one or two more days to see if any voices
requesting the bot-comments to stay/change will rise
up (I don't expect that). Otherwise I'll disable the
comments at all and leave just the github status check.
To the idea of editing one comment - we are using
jenkins job builder plugin and I don't know if such
functionality is there (I don't think so)
To Angel's nitpick - We are aware of the fact, that
having jobs behind VPN is not community friendly at
all. And it's on our to-do list to move them from
there right after we move jobs from codenvy CI infra.
P.S.: I was quickly experimenting with putting the
info from comment into the text of the status check,
as it also supports markdown
(https://developer.github.com/v3/checks/runs/), but it
seems that the `message` argument is limited with
maximum size of 140 chars (this is not mentioned in
the github docs), so it's not fit for our usecase. But
anyway... The "details" link stays there and all
required info should be accessible from there.
On Thu, Dec 5, 2019 at 12:40 PM Sun Tan
<sutan@xxxxxxxxxx <mailto:sutan@xxxxxxxxxx>> wrote:
Updating a comment does not send any new
notifications ...
Sun Tan
Senior Software Engineer
/Eclipse Che - CodeReady Workspaces /@ Red Hat
/Paris JUG leader/
Red Hat Paris <https://www.redhat.com/>
sutan@xxxxxxxxxx <mailto:sutan@xxxxxxxxxx>
M: +33621024173 <tel:+33621024173>
@sunsengdavidtan
<https://twitter.com/sunsengdavidtan> me
<https://www.linkedin.com/in/sun-seng-david-tan-b05a684/>
<https://www.redhat.com/>
On Thu, Dec 5, 2019 at 12:06 PM Michal Vala
<mvala@xxxxxxxxxx <mailto:mvala@xxxxxxxxxx>> wrote:
If updating a comment fires the notification,
I'm against. Still option to enable/disable
looks better to me.
On Thu, Dec 5, 2019 at 10:59 AM Sun Tan
<sutan@xxxxxxxxxx <mailto:sutan@xxxxxxxxxx>>
wrote:
maybe the bot could just update the same
comment, adding or updating the status
Sun Tan
Senior Software Engineer
/Eclipse Che - CodeReady Workspaces /@ Red Hat
/Paris JUG leader/
Red Hat Paris <https://www.redhat.com/>
sutan@xxxxxxxxxx <mailto:sutan@xxxxxxxxxx>
M: +33621024173 <tel:+33621024173>
@sunsengdavidtan
<https://twitter.com/sunsengdavidtan> me
<https://www.linkedin.com/in/sun-seng-david-tan-b05a684/>
<https://www.redhat.com/>
On Mon, Dec 2, 2019 at 11:39 PM Angel
Misevski <amisevsk@xxxxxxxxxx
<mailto:amisevsk@xxxxxxxxxx>> wrote:
On 11/27/19 8:04 AM, Sergii Kabashniuk
wrote:
>
>
> On Wed, Nov 27, 2019 at 1:44 PM
Thomas Mäder <tmader@xxxxxxxxxx
<mailto:tmader@xxxxxxxxxx>
> <mailto:tmader@xxxxxxxxxx
<mailto:tmader@xxxxxxxxxx>>> wrote:
>
>
> On 27/11/2019 12:58, Michal Vala
wrote:
> > I'd like to propose to
disable che-bot comments by default and
> make it
> > possible to enable it with a
label. If disable by default is not
> > acceptable for whatever
reason, at least make it possible to
disable
> > che-bot comments with a label.
> >
> > What do you think?
>
> +1
>
> +1
I'm also +1, but to add to the
question: how useful are the comments
left by che-bot in general?
The bot comment includes
- A link to the build
- A link to the test report (which can
be retrieved from the build link)
- the built-and-tagged image, if
applicable
I've found having easy access to e.g.
the built image for testing very
useful in the past, but I don't know
if having that is worth the extreme
amount of comment spam we can have.
In addition, the happy path and OCP
e2e tests seem to output different
images, e.g. maxura/che-server:14540
vs eclipseche/che-server:14540.
If we disable bot comments completely,
the jobs should still be
accessible via the details link in the
checks section of the merge UI,
so it would seem that having the
comments at all is not incredibly useful.
Side nitpick: it's kind of strange
that one of the CI jobs links to a CI
that requires RH VPN.
>
>
> /Thomas
>
>
_______________________________________________
> che-dev mailing list
> che-dev@xxxxxxxxxxx
<mailto:che-dev@xxxxxxxxxxx><mailto:che-dev@xxxxxxxxxxx
<mailto:che-dev@xxxxxxxxxxx>>
> To change your delivery options,
retrieve your password, or
> unsubscribe from this list, visit
>
https://www.eclipse.org/mailman/listinfo/che-dev
>
>
>
> --
>
> Sergii Kabashniuk
>
> Principal Software Engineer, DevTools
>
> Red Hat
>
>skabashniuk@xxxxxxxxxx
<mailto:skabashniuk@xxxxxxxxxx><mailto:skabashniuk@xxxxxxxxxx
<mailto:skabashniuk@xxxxxxxxxx>>
>
>
>
_______________________________________________
> che-dev mailing list
>che-dev@xxxxxxxxxxx
<mailto:che-dev@xxxxxxxxxxx>
> To change your delivery options,
retrieve your password, or unsubscribe
from this list, visit
>https://www.eclipse.org/mailman/listinfo/che-dev
>
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
<mailto:che-dev@xxxxxxxxxxx>
To change your delivery options,
retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
<mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve
your password, or unsubscribe from this
list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--
Michal Vala
Software Engineer, Eclipse Che
Red Hat Czech
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your
password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your
password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your
password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--
MykolaMorhun
Software Engineer
Red Hat<https://www.redhat.com/>
<https://www.redhat.com/>
--
With best regards,
Dmytro Nochevnov
Senior Quality Engineer
Che QE team
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
