Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] About versions of Che 7 plugins and editors
We haven’t implemented transitive dependencies if you mean that. 

пт, 21 дек. 2018 г. в 19:39, Sergii Kabashniuk <skabashn@xxxxxxxxxx>:


On Fri, Dec 21, 2018 at 7:23 PM Oleksandr Garagatyi <ogaragat@xxxxxxxxxx> wrote:
Mario suggested usage of strict version for that. 
If this is so needed we could also add configuration to Che master to forbid non-strict version usage, but it doesn't seem that needed for me.
 
This is a good answer for first level dependencies. 
What about a third and others? Are we going to provide some kind of plugin.version.lock file that will list the whole chain of dependencies like [1]-[3]?

Practical example:
My workspace:
 plugins: p1:v1(strict)
 
p1 has strict dependency d2
d2 has dependency d3 with a range of version x.(?)
How can I protect myself from braking changes in dependency d3?





On Fri, Dec 21, 2018 at 7:19 PM Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:
I do like the power that these features provide, providing them we need to make
sure we have proper answers for some non-obvious circumstances like:
- I'm an enterprise customer with high SLA requirements.
   How I can make sure that plugins that I'm used are not affected by "npm left pad chaos" [1].
   Shortly speaking how can I can protect myself from breaking changes that
authors of transitive(first-second -..... level) dependencies can make.
- Reproducible workspaces are no longer guarantee for 100%, but what If I want?


WDYT What would be your answer for this?


On Fri, Dec 21, 2018 at 3:02 PM Stevan LeMeur <slemeur@xxxxxxxxxx> wrote:
Thanks mario for summarizing.

Works for me too.

On Fri, Dec 21, 2018 at 2:01 PM Oleksandr Garagatyi <ogaragat@xxxxxxxxxx> wrote:
+1 to proposed case 1 and 2 solutions. 
And even if version range for a plugin would be interesting for the community we could add this feature later.


On Fri, Dec 21, 2018 at 2:10 PM Mario <mario.loriedo@xxxxxxxxx> wrote:

An initial discussion about Che 7 plugins versions was started on https://github.com/eclipse/che/issues/12168. It's an important topic and I would like to bring it here to reach more people.

The questions are quite simple:

1. when defining the plugins of a workspace, should a user specify a particular version? no version at all? a specific range of versions (e.g. using ~ and ^ npm annotations)

  - name: exec-plugin
    type: chePlugin
    id: che-machine-exec-plugin:0.0.1

2. and what about when, in a plugin definition, the maintainer of the plugin need to specify the editors compatible with the plugin (e.g. theia)? Should he specify the compatible versions of the editor as well? What about a range of versions?

editors:
  - id: org.eclipse.che.editor.theia:1.0.0

I think that for case 1. we should support:

- no version (defaults to latest version of plugin, that's what most of the people that try Che for the first time want)

- specific version (that's for people that look for reproducible workspaces, one of Che promises)

For 2. we should support:

- no version (the plugin is compatible with whatever version of Theia Che is using)

- a range of versions (using ~ and ^ the npm way)

Mario

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

OLEKSANDR GARAGATYI

SENIOR SOFTWARE ENGINEER

Red Hat 

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

Stévan LeMeur // Product Manager // Developer Tools // +336-87-11-27-55 

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

Sergii Kabashniuk

Principal Software Engineer, DevTools 

Red Hat Ukraine

skabashniuk@xxxxxxxxxx    

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

OLEKSANDR GARAGATYI

SENIOR SOFTWARE ENGINEER

Red Hat 

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

Sergii Kabashniuk

Principal Software Engineer, DevTools 

Red Hat Ukraine

skabashniuk@xxxxxxxxxx    

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--
Oleksandr Garagatyi

Back to the top