| Re: [che-dev] ci-build-check now required |
Check on "Require branches to be up to date before merging" has been disabledFlorentOn Tue, Nov 27, 2018 at 11:19 AM Roman Iuvshyn <riuvshyn@xxxxxxxxxx> wrote:We did not requested branch up-to-date check it was enabled by eclipse admins. If we want to disable this check we have to file a bug on https://bugs.eclipse.org and ask webmaster to do it.I'm ok if it will be disabled but we will have build check enabled and required, because if PR does not compile it should not be merged.On Tue, Nov 27, 2018 at 11:20 AM <tmader@xxxxxxxxxx> wrote:_______________________________________________On Mon, 2018-11-26 at 11:39 +0200, Roman Iuvshyn wrote:@Florent Benoit we didn't request require of branch being up-to-date seems eclipse org enabled this automatically. I was not aware that it was enabled for CHE repos but I think this is very important and thing to have.Sorry, Roman, but I have to disagree here: how many times did a merge of a non-conflicting, but not-up-to-date PR break the build in the last year? IMO, this check is solving a non-problem. I think we're going down the wrong path here entirely: we're trying to make sure no-one can ever make a mistake. In exchange, we're making it harder for people to contribute. We need to find a balance.Please get rid of this check again!/Thomas
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--