On Mon, Nov 26, 2018 at 5:32 PM Sergii Kabashniuk
<skabashn@xxxxxxxxxx <mailto:skabashn@xxxxxxxxxx>> wrote:
On Mon, Nov 26, 2018 at 12:11 PM Roman Iuvshyn
<riuvshyn@xxxxxxxxxx <mailto:riuvshyn@xxxxxxxxxx>> wrote:
@Florent Benoit <mailto:fbenoit@xxxxxxxxxx> I do not think
that this ticket is related to to branch up to date
requirement it was set before we've asked for make ci-build
required check.
I think both checks are important and should be forced to
avoid situations where PR can be merged and break build.
ok. then who wants to merge this pr
https://github.com/eclipse/che/pull/12022 ?
On Mon, Nov 26, 2018 at 11:59 AM Florent Benoit
<florent@xxxxxxxxxx <mailto:florent@xxxxxxxxxx>> wrote:
@Roman Iuvshyn <mailto:riuvshyn@xxxxxxxxxx>
I think then we should comment on
https://bugs.eclipse.org/bugs/show_bug.cgi?id=541086
that it's mostly a "loose" required check instead of a
"strict" required check.
On Mon, Nov 26, 2018 at 10:40 AM Roman Iuvshyn
<riuvshyn@xxxxxxxxxx <mailto:riuvshyn@xxxxxxxxxx>> wrote:
@Florent Benoit <mailto:fbenoit@xxxxxxxxxx> we
didn't request require of branch being up-to-date
seems eclipse org enabled this automatically. I was
not aware that it was enabled for CHE repos but I
think this is very important and thing to have.
@Ilya Buziuk <mailto:ibuziuk@xxxxxxxxxx> I will
check if you are in the white list
On Mon, Nov 26, 2018 at 11:25 AM Ilya Buziuk
<ibuziuk@xxxxxxxxxx <mailto:ibuziuk@xxxxxxxxxx>> wrote:
I also noticed it while reviewing
https://github.com/eclipse/che/pull/11989
pressing update branch creates a merge commit,
which breaks ip validation
also, it seems that ci*-**build *does not
trigger the build check for me
On Mon, Nov 26, 2018 at 10:01 AM Florent Benoit
<florent@xxxxxxxxxx <mailto:florent@xxxxxxxxxx>>
wrote:
Roman,
I noticed that the buttons to merge are also
requiring to merge with latest. (AFAIK It
was not discussed previously)
an example : To merge a typo PR from some an
external contributor, this mandatory 'merge'
is not working at all as it's requiring
contributors to update their pull request at
each new commit to master branch.
Regards,
Florent
On Wed, Nov 21, 2018 at 10:18 AM Roman
Iuvshyn <riuvshyn@xxxxxxxxxx
<mailto:riuvshyn@xxxxxxxxxx>> wrote:
hello,
please be informed that now
*ci-build-check* is required for every
PR against eclipse/che repository this
check will be started automatically and
can be restarted by *ci-build
*trigger phrase in the PR comment.
*
*
*ci-test *is still required to run for
most PRs
--
ROMAN IUVSHYN
Red Hat
<https://www.redhat.com/>
riuvshyn@xxxxxxxxxx
<mailto:riuvshyn@xxxxxxxxxx>
<https://red.ht/sig>
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
<mailto:che-dev@xxxxxxxxxxx>
To change your delivery options,
retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve
your password, or unsubscribe from this
list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--
ILYA BUZIUK
SENIOR SOFTWARE ENGINEER
Red Hat
<https://www.redhat.com/>
ibuziuk@xxxxxxxxxx <mailto:ibuziuk@xxxxxxxxxx>
<https://red.ht/sig>
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your
password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--
ROMAN IUVSHYN
Red Hat
<https://www.redhat.com/>
riuvshyn@xxxxxxxxxx <mailto:riuvshyn@xxxxxxxxxx>
<https://red.ht/sig>
--
ROMAN IUVSHYN
Red Hat
<https://www.redhat.com/>
riuvshyn@xxxxxxxxxx <mailto:riuvshyn@xxxxxxxxxx>
<https://red.ht/sig>
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--
Sergii Kabashniuk
Principal Software Engineer, DevTools
Red Hat Ukraine
skabashniuk@xxxxxxxxxx <mailto:skabashniuk@xxxxxxxxxx>
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--
ROMAN IUVSHYN
Red Hat
<https://www.redhat.com/>
riuvshyn@xxxxxxxxxx <mailto:riuvshyn@xxxxxxxxxx>
<https://red.ht/sig>
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx <mailto:che-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
--
Sergii Kabashniuk
Principal Software Engineer, DevTools
Red Hat Ukraine
skabashniuk@xxxxxxxxxx <mailto:skabashniuk@xxxxxxxxxx>
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
