Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] Eclipse Che: Merged or closed PR
A gentle reminder to remove branches related to merged and closed PR. 
If there are no reasonable objections I'm going to drop them next time without the warning if they are more then 1 week old. 

On Thu, Dec 7, 2017 at 7:48 AM, Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:
Cleanup complete.
Archive in attachments
 che.git.zip
​

On Wed, Dec 6, 2017 at 2:28 PM, Max Rydahl Andersen <manderse@xxxxxxxxxx> wrote:

Is everyone aware on GitHub you can now click "Allow edits from maintainers" on PR's that allow
maintainers to do work on the PR branches ? (https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

That gives best of all worlds and those who are not contributors to main Che repo and add additional collaborators meaning
it is actually even more open and collaborative if you think about it :)

/max
http://about.me/maxandersen

On 6 Dec 2017, at 12:17, Jonah Graham wrote:

Hi folks,

In the idea of keeping the dev process open I would highly encourage that any long term or collaborative branches be kept in the main che repo.

Thanks
Jonah


~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On 6 December 2017 at 10:05, Gennady Azarenkov <gazarenk@xxxxxxxxxx> wrote:
I see no problems in either way. I'd prefer disciplined management of branches/PRs as a part of Che repo but it is up to developer which way to choose in general.
I.e. owner of branch/PR should care not only of creating but removing as well, otherwise it will be identified as non-actual and removed in some time of non-activity (3 months looks reasonable to me) as a part of housekeeping exercise.


On Wed, Dec 6, 2017 at 11:33 AM, Radim Hopp <rhopp@xxxxxxxxxx> wrote:
Huge +1 to topic branches in forked repos. Right now, looking at che git repo history is almost like looking at map of Tokyo subway.


On Wed, Dec 6, 2017 at 8:36 AM Oleksandr Garagatyi <ogaragat@xxxxxxxxxx> wrote:
Hi. I want to discuss a topic related to this cleanup. Why not keep branches in dev's own forks? Some Che committers do this and some not. With this approach, we won't need such a cleanup and whole repo would be cleaner. Sure there are cases when multiple ppl work on the same branch but this is a rare case, mostly feature branch is developed by dev and never gets checked out by other community members.
HDYT, should we recommend this approach to committers?

On Wed, Dec 6, 2017 at 9:12 AM, Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:
Reminder.
Tomorrow I'll drop branches related to closed or merged PRs.

Next topic.

I want to drop all branches older than 3(discussable value) months. For those
who might interest in that old branches, I may attach bare repository
archive. 


On Tue, Dec 5, 2017 at 1:15 PM, Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:
All
Please take a look at your branches
If they are don't needed, or PR is closed or merged, please remove it.

Unless someone notifies me, I'm going to remove  branches
related to closed or merged PRs in a day or two.

Cheers 


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev




--

OLEKSANDR GARAGATYI

SENIOR SOFTWARE ENGINEER

Red Hat 

--


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



Back to the top