Re: [che-dev] PHP related PR waiting for review

[Kaloyan Raev <kaloyan.r@xxxxxxxx>]

Hi Tyler,

Thanks for pointing me to the correct wiki. Please note that the Che project page [1] points to an outdated wiki [2]. Perhaps, you would want to remove [2] and update [1] to the correct one.

I found the Weekly Planning Meetings wiki page [3]. There the last documented meeting is from July 19. Are these meetings still happening?

I also read about the dev process [4]. If the process was really followed both PRs should have already been merged.
Quote:
> For the immediate upcoming milestone, we will only accept features who have a pending pull request which has been tested and ready for merge. This will allow the entirety of the iteration to be dedicated to hardening the system and resolving any infrastructure or regressions that appear. Che maintainers may optionally accept pull requests that are initiated during a milestone if they are deemed to have a low risk to destabilizing the code base for the release.

It's hard to imagine a simpler and lower risk feature than #2160 and simpler and lower risk bugfix than #2263. They haven't been even triaged. So, it seems to be a matter of priority given to community contributions.

Also note that my team is in an early stage of introducing PHP support in Che. Our first goal is to estimate the realistic effort for providing a complete PHP support. If a simple one-liner PR waits for weeks and months then, I am afraid, the estimation won't be viable enough for a positive investment decision.

If the Che project wants to grow the community base, it should give higher priority for community contributions, build a diverse committers base, and adapt the dev process to involve the non-Codenvy committers.

[1] https://projects.eclipse.org/projects/ecd.che
[2] https://wiki.eclipse.org/Che
[3] https://github.com/eclipse/che/wiki/Weekly-Planning-Meetings
[4] https://github.com/eclipse/che/wiki/Development-Process

Kaloyan

On 09/14/2016 06:49 PM, Tyler Jewell wrote:

We are working to keep all the details on the entire dev process documented here:

https://github.com/eclipse/che/wiki

We have had problems in the past with early merges that destabilize the system - so PRs are not merged until a team lead + QA engineers are allocated into a sprint for review, documentation consideration, test, and maintenance plan confirmed. So even simple PRs still have to be scheduled in.  It's not very quick, but it is a more stable process.

Tyler

Tyler Jewell | CEO | tyler@​codenvy.​com | 9​78​.8​84​.53​55

On Wed, Sep 14, 2016 at 8:10 AM, Kaloyan Raev <kaloyan.r@xxxxxxxx> wrote:

Hi Tyler,

Can you give any info about "the weekly Tuesday sessions" where "the planning conversations for current and upcoming sprints occur". I don't find any info about them. They are also not mentioned in the CONTRIBUTING document: https://github.com/eclipse/che/blob/master/CONTRIBUTING.md

I don't really understand your comment that these PR require more work to be done in order to be merged. If anything blocks them from merging, please add a comment in the respective PR.

Note that #2263 is a very simple change. I don't think it requires anything else to be merged.

Thanks,
Kaloyan

On 09/14/2016 04:35 PM, Tyler Jewell wrote:

We do all of our planning around issues & pull requests to be taken in GitHub. Please make sure that your pull requests are up to date with your timing and requests.  The planning conversations for current and upcoming sprints occur on the weekly Tuesday sessions.

We hope to burn down open PRs before our 5.0.0 GA release this fall.

On PHP - there will need to be templates, default commands, and a review of stacks. So accepting the PRs drags along other work to be done.

Tyler Jewell | CEO | tyler@​codenvy.​com | 9​78​.8​84​.53​55

On Wed, Sep 14, 2016 at 4:09 AM, Kaloyan Raev <kaloyan.r@xxxxxxxx> wrote:

Hi,

We have a couple of pull requests related to PHP support:
- Basic PHP plugin: https://github.com/eclipse/che/pull/2160
- Enable syntax highlighting for *.phtml files: https://github.com/eclipse/che/pull/2263

We will appreciate if they are reviewed and merged.

Thanks,

Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

-- Kaloyan Raev | Zend Studio Team Lead Rogue Wave Software, Inc. Accelerating Great Code M +359 887 648 663 www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx

_______________________________________________ che-dev mailing list che-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/che-dev

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

-- Kaloyan Raev | Zend Studio Team Lead Rogue Wave Software, Inc. Accelerating Great Code M +359 887 648 663 www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx