Re: [che-dev] PHP related PR waiting for review

[Tyler Jewell <tyler@xxxxxxxxxxx>]

We are working to keep all the details on the entire dev process documented here:

https://github.com/eclipse/che/wiki

We have had problems in the past with early merges that destabilize the system - so PRs are not merged until a team lead + QA engineers are allocated into a sprint for review, documentation consideration, test, and maintenance plan confirmed. So even simple PRs still have to be scheduled in.  It's not very quick, but it is a more stable process.

Tyler

Tyler Jewell | CEO | tyler@​codenvy.​com | 9​78​.8​84​.53​55

On Wed, Sep 14, 2016 at 8:10 AM, Kaloyan Raev <kaloyan.r@xxxxxxxx> wrote:

Hi Tyler,

Can you give any info about "the weekly Tuesday sessions" where "the planning conversations for current and upcoming sprints occur". I don't find any info about them. They are also not mentioned in the CONTRIBUTING document: https://github.com/eclipse/che/blob/master/CONTRIBUTING.md

I don't really understand your comment that these PR require more work to be done in order to be merged. If anything blocks them from merging, please add a comment in the respective PR.

Note that #2263 is a very simple change. I don't think it requires anything else to be merged.

Thanks,
Kaloyan

On 09/14/2016 04:35 PM, Tyler Jewell wrote:

We do all of our planning around issues & pull requests to be taken in GitHub. Please make sure that your pull requests are up to date with your timing and requests.  The planning conversations for current and upcoming sprints occur on the weekly Tuesday sessions.

We hope to burn down open PRs before our 5.0.0 GA release this fall.

On PHP - there will need to be templates, default commands, and a review of stacks. So accepting the PRs drags along other work to be done.

Tyler Jewell | CEO | tyler@​codenvy.​com | 9​78​.8​84​.53​55

On Wed, Sep 14, 2016 at 4:09 AM, Kaloyan Raev <kaloyan.r@xxxxxxxx> wrote:

Hi,

We have a couple of pull requests related to PHP support:
- Basic PHP plugin: https://github.com/eclipse/che/pull/2160
- Enable syntax highlighting for *.phtml files: https://github.com/eclipse/che/pull/2263

We will appreciate if they are reviewed and merged.

Thanks,

Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

--
Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev