Hi,
I was wondering what the status of this PR is now? Will this be merged for 3.11.0? If not, then when will it be merged?
Regards,
Lior
From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx]
On Behalf Of Gennady Azarenkov
Sent: Monday 01 June 2015 16:34
To: che developer discussions
Subject: Re: [che-dev] Changing the project metadata folder name to ".che"
Thanks, we'll look at it ASAP and let you know.
On Mon, Jun 1, 2015 at 4:09 PM, Okman, Lior <lior.okman@xxxxxxx> wrote:
Hi,
The pull request included code that migrates projects and modules with pre-existing “.codenvy” folders
to the “.che” format. This is done in the PR I submitted automatically, and I also included a unit-test to verify that it happens when a project is accessed.
I completely agree that this needs more testing on staging, in order to verify that there is nothing
missing – is there any way I can help getting this done?
Regards,
Lior
From:
che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx]
On Behalf Of Gennady Azarenkov
Sent: Monday 01 June 2015 13:40
To: che developer discussions
Subject: Re: [che-dev] Changing the project metadata folder name to ".che"
Hi Lior,
Well, at some point we would need to do something like that, thanks for your work.
But, I am not sure if we are able to apply those changes shortly. The problem is that we already have a lot of projects with ".codenvy/*" (on
codenvy.com and on-prem accounts) so even if they do not fail with ".che" it does not mean they continue to work correct.
I am not sure but feel that we will also need some migration procedure, more testing on staging etc.
I mean I am basically OK with your proposal but not sure when we can apply it.
On Sun, May 31, 2015 at 9:26 AM, Okman, Lior <lior.okman@xxxxxxx> wrote:
Hi,
When using the Eclipse Che default project manager implementation, the resulting files are saved in a “.codenvy” folder saved in the root of the project. I would like to suggest
that this be changed from “.codenvy” to “.che” in order to not tie filenames created without the Codenvy part to Codenvy.
I’ve submitted two pull-requests to this effect, one on the che-core repository (https://github.com/codenvy/che-core/pull/89)
and the other in the che-plugins repository (https://github.com/codenvy/che-plugins/pull/131 - this pull-request depends on changes made in the che-core repository).
The pull-requests also fix usages of the “.codenvy” string literally, instead of using the relevant constant in the projects API, and add some compatibility code so that accessing
a project that has a “.codenvy” folder instead of a “.che” folder will not fail.
Regards,
Lior Okman
Area Architect, Development Experience, Technology Cloud Experience
SAP Labs Israel,
15 Hatidhar st., Raanana 43665, Israel
M
+972-54-338-8481
T +972-9-777-9816
Lior.Okman@xxxxxxx
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev
|