Re: [che-dev] Lucene search enhancements

[Sergii Kabashniuk <skabashnyuk@xxxxxxxxxxx>]

Hello

On Mon, May 25, 2015 at 1:10 PM, Sirich, Rima <rima.sirich@xxxxxxx> wrote:

Hello,

 

I would like to enhance Lucene search capabilities therefore I created a pull request

( https://github.com/codenvy/che-core/pull/77 ) with following changes:

 

1. queryParser.setAllowLeadingWildcard(true) enables performing contains query ( like *uer* ) 

I'm not sure about that. I think different vendors may want to have custom behaviour of QueryParser. Wdyt maybe we should allow to extend it in the same way like we do for Analyzer or Directory or IndexWriter

2. SimpleAnalyzer uses LetterTokenizer with LowerCaseFilter, that means that it creates tokens by broking a text by non-letter characters, therefore in current implementation it is not possible to search for the text containing special characters. Using WhitespaceTokenizer solves this issue as it creates tokens by broking a text by whitespace.

 

I tend to agree with you. If discussion of 1 will be long may be you should decouple this tasks. 

 

I would very appreciate if you could have a look on this pull request and consider merging it to master.

 

Thanks & Best Regards,

Rima Sirich

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

Sergii Kabashniuk