| Re: [che-dev] Workspace ID generation |
|
Hi Gennady, Meirav is on short vacation, so I'll try to answer
J Our tendency is to go with injectable component (as workspace ID generation might be specific in our case) and reusing NameGenerator code for basic/standard
solution. Thanks, Zoya From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx]
On Behalf Of Gennady Azarenkov Hi, Makes sense. We have not paid a lot of attention on it (did not consider it as a big deal :) ), so, sure. Do you also think that ID generating algo should be injectable as a component? Or your generator supposed to be good enough for all the cases and we can just replace the utility method? Best, Gennady
Gennady Azarenkov - CTO @
codenvy.com On Tue, Mar 3, 2015 at 3:30 PM, Daniel, Meirav <meirav.daniel@xxxxxxx> wrote: HI All, I am a Senior developer and Scrum master at SAP Cloud Development Experience core team. We are evaluating CHE API SDK as our part of SAP Cloud development experience. We identify that workspace ID is generated during workspaceService.create API by Che NameGenerator "NameGenerator.generate(Workspace.class.getSimpleName().toLowerCase(),
ID_LENGTH)" Since this "workspace ID" is used for the Root Folder name of the workspace we would like override /control the ID generation to make it more secured and non-predictable. We were thinking of moving this logic from WorkspaceService Class to Workspace DAO and contribute this change back to Che (by pull request ) Do we understand the flow correctly ? Is our intention acceptable with you ? Do you have other suggestion for doing that ? Thanks & Regards, Meirav Daniel
Cloud Development Experience | SAP Labs Israel | 15 Hatidhar st, Raanana 43665, Israel
|