Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] [ptp-dev] future of LRParser, XLC and UPC specific support in CDT

After looking at this I believe that the removal of LRParser, XLC and UPC is not equivalent to other cases I am looking at. I would like to push for the removal of these in the 9.11.0 timeframe. Please let me know if there are any concerns with this on Bug 558994 that I am using to track the removal process.

Thanks,
Jonah


~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Thu, 9 Jan 2020 at 14:50, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
I submitted Bug and Gerrits for the PTP removal: https://bugs.eclipse.org/bugs/show_bug.cgi?id=558992

As I mentioned in the bug, if you are happy to go with it you can remove the UPC contribution to simrel right away by reviewing https://git.eclipse.org/r/#/c/155569/

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Thu, 9 Jan 2020 at 14:30, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
Sounds good.

Thanks
Greg

On Jan 9, 2020, at 9:33 AM, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

Thanks Greg and Marc-Andre,

I will add this to the list of handling how to delete things from CDT. Greg, if we go with deletion I'll try to provide a gerrit to PTP to delete the dependants too, but it will mean some amount of synchronization of releases to SimRel so that doesn't get broken.

Thanks
Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Thu, 9 Jan 2020 at 09:01, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
If no one is maintaining them, then I think they should be removed.  I’m not sure that UPC is being used much any more anyway. Most HPC development seems to have migrated to C++ now.

Regards,
Greg

On Jan 9, 2020, at 12:45 AM, Marc-Andre Laperle <malaperle@xxxxxxxxx> wrote:

I think it would be good to remove these. If there is something left to be used by PTP, maybe it can be moved there. I don’t recall the outcome of the previous conversations about this but perhaps it was the same conclusion but no one had the time to look into moving things.

Marc-André

On Jan 8, 2020, at 1:13 PM, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

Hello folks,

This is a continuation of my ongoing review of what is in CDT. 

The LRParser, XLC and UPC components are currently part of our release and the SimRel, but it is not part of C/C++ IDE EPP project. UPC/LRParser is part of the Eclipse IDE for Scientific Computing and PTP has a project[0] that requires UPC  (which is why ptp-dev is included in this email).

The current state of these components is all similar. There has not been any substantive bugs fix in 7+ years in them, nor any bug reports. Virtually all the commits to these components have been cleanup and releng for years.
They each have a testsuite, but those suites have not been run as part of the build for a few years now. They can be run manually, but there are lots of failures. The failures are a combination of things, but include not handling new token types that have been added to CDT over the years[1] and that the tests cause assertions[2] in the core CDT code when run.

From this preliminary examination it looks improbable that anyone could be using this code. Does anyone know of any uses? 

Thank you,
Jonah


[0] /tools/pldt/org.eclipse.ptp.pldt.upc
[1] tUSER_DEFINED_STRING_LITERAL added in Bug 379684 Support for User Defined Literals is not handled in case statements. See AST2CPPTests.testUserDefinedLiteralConcatenation2c
[2] CPPASTQualifiedName.setLastName(ICPPASTName) has an assertion that is hit when running the tests


~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ptp-dev

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ptp-dev

Back to the top