Re: [capra-dev] Notification system in artifact handler breaks support f

[Jens Lideström <jens.lidestrom@xxxxxxxxxxx>]

Maybe there could be a simple temporary fix to make it possible to use an alternative model even if the generic model is installed.

If the notification code would check that its dealing with a generic and just return otherwise then maybe there would not be a problem. (It could check this just by using instanceof.)

But we would still need a way to specify that we want the ReqTool model to be used, even if the generic model is present. Right now its a matter of chance I think. Sometimes it works because the ReqTool model happens to be first in the list of extension point contributions; sometimes it doesn't work.

Of course, it would be even better if a real solution was found to make the notification system worked with alternative models.

/Jens

2017-06-29 12:05 GMT+02:00 Salome Maro <salome.maro@xxxxxxxxx>:

Hi Jens,

 

Sorry this broke ReqTool.

 

I think we can make this notification feature more generic and get rid of the dependency. I ll spend some time today after lunch and make a fix for that. Will get back to you as soon as the patch lands.

 

Best regards,

 

Salome.

 

 

From: <capra-dev-bounces@xxxxxxxxxxx> on behalf of Jens Lideström <jens.lidestrom@xxxxxxxxxxx>
Reply-To: capra developer discussions <capra-dev@xxxxxxxxxxx>
Date: Thursday, 29 June 2017 at 11:11
To: capra developer discussions <capra-dev@xxxxxxxxxxx>
Subject: Re: [capra-dev] Notification system in artifact handler breaks support for external models

 

Now I've talked with Hans-Erik and you were apparently already aware of this issue, so there was probably no reason for me to write the earlier mail.

Just lets try to find a solution as fast as possible!

BR,

Jens Lideström

Software developer
rt-labs

 

2017-06-29 11:04 GMT+02:00 Jens Lideström <jens.lidestrom@xxxxxxxxxxx>:

Hello,

I noticed that after a change in the notification system Capra has completely lost the ability to run other models than the generic model.

This completely breaks ReqTool and all sorts of model extendability. This urgently has to be reworked.

This change is this:

https://git.eclipse.org/r/#/c/93502/

* It introduced a dependency on the generic model from all artifact handlers.

* It assumes that the model is the generic model and crashes otherwise. See for example JavaElementChangeListener.

 

Optimally a notification system that doesn't depend on any particular model should be developed. Until that happens *all code that depends on the generic model should be moved out of the artifact handlers*!

BR,

Jens Lideström

Software developer
rt-labs

 

_______________________________________________
capra-dev mailing list
capra-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/capra-dev