Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [yasson-dev] is the master branch for 1.0.2 development?

Hi Dmitry,


On Wed, Apr 25, 2018 at 5:06 PM, Dmitry Kornilov <dmitry.kornilov@xxxxxxxxxx> wrote:
Hi Scott,

I think that I am seeing a regression with the master branch, that wasn't in 1.0.1.  With help, I have now recreated the failure with [1].  I would like to help find the cause of the reproduced failure and would like to see a 1.0.2 release with the fix.  Is master working towards a 1.0.2 release?

Yes, master goes towards 1.0.2. I’ll ask someone to check why behaviour is changed.

By the way, the failure is per jsonb specification section 3.11:
"
JSON Binding implementations MUST report a deserialization error if a default constructor is not present or is not in accessible scope.
"

I believe that the [1] test is showing that the above is not happening.  I think the next step is to 'git bisect' and find the cause, then create an issue.

I am not convinced with your logic. Default constructor is generated by the compiler if there are no constructors present. The spec means that a public no-arg constructor must be present, which is true in your case (it’s automatically provided).

I missed that and corrected the pull request, so there is no such bug on master, I was wrong.  Thanks! :)

Scott
 

_______________________________________________
yasson-dev mailing list
yasson-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/yasson-dev



Back to the top