Hello,
We have compared CVS
newest version with our local changes. Some of bugs has
similar fixes, however there are still some which have
not been fixed yet. Proposed fixes are in attached
diffs. We tried to test our fixes using existing files
in test case by adding methods to TestBugs.java.
1. FnAbs: http://www.w3.org/TR/xquery-operators/#func-abs
According to http://www.w3.org/TR/xpath20/#id-function-callsif sequence is expected (indicator *, +, or
?) the atomization of arguments should be applied. Now
in case of node passed to method type error occur.
However there is some support for atomization -
FnDistinctValues was fixed lately. Test case:
TestBugs:testFunctionAtomization()
We think that in
other numeric function similar errors can occur, suppose
other tests should be added. Surprisingly there are no
tests for that sort of situation in conformance suit (at
least we haven’t found any).
2. FnIndexOf: http://www.w3.org/TR/xquery-operators/#func-index-of
Function should
support any atomic values. It seems that there is no
support for QNames.
TestBugs:testFnIndexOf_onQName(),TestBugs:testFnIndexOf_onQName2()
Second test function
leads to third problem.
3. QName._expanded
which is boolean value saying if namespace was set (also
null if default). When qname is created by function with
empty first argument:
http://www.w3.org/TR/xquery-operators/#func-QName
then ._expanded is
‘true’(we think it’s correct)
but to compare it
with qname from element will always return ‘false’ since
Element.node_name() sets ._expanded to ‘false’ in case
of null namespace (w3c.org
representation of no-namespace situation is null).
Removing if
statement in constructor (QName:45) seems to solve the
problem and do not affected other tests. However we are
not sure about correct ._expanded parameter state. What
is Your opinion?
4. FnPlus used to
have System.exit() line which caused us some trouble to
trace. It was fixed but still there are plenty
System.out statements for some unusual errors. Why just
simply throw an exception?
We are still
investigating other differences trying to run our
application on new library version. We will get back to
You with any other fixes. In the meantime please let us
know what do You think about those.
Regards,
Wojciech Diakowski
and
Łukasz Wycisk