Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-releng] Smoke Test Request for WTP 3.10.0 I-build
Apologies to Neil & the Dali team - when last I looked at the 3.9.3 page it hadn't been updated - I guess it was updated a couple hours later according to the wiki history. This process of having to hunt for checkmarks seems needlessly difficult. Why can't we just assume the smoke passes unless someone announces on this list that there's a problem before a predefined cutoff time? If we all know there's a smoke test coming, surely we can plan to allocate an hour in a 24hr period to do the smoke test? What if we announced the smoke test further in advance, so people can better plan?

In JBoss Tools, we announce a code freeze a few days before the Wed at the end of our 3-week sprints, build the final build on the Thursday, and it's ready for testing/smoke/staging/integration by noon on Thursday, giving people a few days to test it (and call for a respin if needed) before it's released the following Tuesday. This would align well with the Tuesday +2 dates for Oxygen and Photon milestones/RCs. 

Where we're different from WTP is that we assume all is green unless someone (usually dev or QE) calls for a respin between the Wed code freeze and the Tuesday release day. 

---- 

Regarding the build churn, yes, I agree that was unfortunate. That was partly caused by changes in M5 / Tycho 1.1, which I'm still solving. I hope there won't be any more breaking changes for M6, but I'll work more closely with mistria and akurtakov to find out if things are in the pipeline which could impact us. Being forced to move to Tycho 1.1 (because of Dali, platform M5, and Webservices) introduced new issues since Tycho 1.1 is more strict about how it validates source feature/plugin generation. So expect more gerrits to fix that, coming soon. 

Some of the M5 build churn was also caused by stalled gerrits. For example, there's a broken test in servertools [1] which I attempted to disable since it's testing an obsolete/deprecated update site format for wtp server adapter discovery, and which once merged, will result in more passing gerrits for servertools. This gerrit has been sitting waiting for review and merge since Jan 15. Two weeks should be unacceptable at any time, but is particularly painful during a milestone smoketest & release period. 


What can we do to prevent these stalls in future? I have some ideas, but I'm wondering what you all think we could do. 

Thanks,

Nick


On Thu, Feb 1, 2018 at 2:01 PM, Carl Anderson <ccc@xxxxxxxxxx> wrote:

Nick,

First, Dali did update the 3.9.3 smoketest page yesterday- please declare/publish the build to download.eclipse.org as soon as possible.
Second, rather than trying to do the M6 smoketest early, I would state that we need to get regular (every two week) declares of WTP 3.10.0. So far, we've had one successful smoketest, and we've had a lot of build churn and feature/plugin movement that have really made things unstable. I would prefer to get these issues resolved before/during the smoke tests leading up to M6, rather than extend the length of the smoketest for M6. (In reality, our smoke tests are only supposed to last one day- issued Thursday morning, declared Friday... but for milestones/releases, it is extended in order to respin on top of prereqs... for example, the platform declares their milestone/release candidate the day after our smoke test begins. Other prereqs can change on Monday, on their +1 day. So we need to hold off declaring until then.)
Thanks again for all of your hard work getting us set up better for CBI and Unit tests.

FWIW,

- Carl Anderson
WTP Releng project lead

Inactive hide details for Nick Boldt ---02/01/2018 09:18:25 AM---Further update: * still ZERO response from Dali (on this or thNick Boldt ---02/01/2018 09:18:25 AM---Further update: * still ZERO response from Dali (on this or the 3.9.3 build)

From: Nick Boldt <nboldt@xxxxxxxxxx>
To: Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>
Date: 02/01/2018 09:18 AM
Subject: Re: [wtp-releng] Smoke Test Request for WTP 3.10.0 I-build
Sent by: wtp-releng-bounces@xxxxxxxxxxx




Further update:

* still ZERO response from Dali (on this or the 3.9.3 build)

* webservices move & merge is complete; however we've hit some build issues as a result

* old enterprise features moved from javaee to webservices can now be disabled/deprecated from the javaee repo [1]

* Photon M5 staging site has been declared, so we missed the boat here. 

For M6, can we do the smoke test more in advance of the cutoff, so there's more time for testing and for everyone to respond? Seems Thurs-Tues was not enough time. How about a full week (or two?) in advance? 

Could we also mandate that every team lead sign into Mattermost "webtools" channel so they're easily reachable for comments / feedback / gerrit reviews & merges? Keith's been amazing this week, and Nitin & Rob are always in there, but there are others that are REALLY difficult to reach. 

[1] https://git.eclipse.org/r/#/c/116062/





On Tue, Jan 30, 2018 at 9:43 AM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
    Two updates:

    a) managed to build WTP integration (releng.aggregator) using Tycho 1.0.0 instead of 1.1.0-SNAPSHOT, despite supposedly needing it for Dali.

    Build: https://hudson.eclipse.org/webtools/job/WTP-R3_10_Integration/244/
    Results: http://build.eclipse.org/webtools/committers/wtp-R3.10.0-I/20180129161428/I-3.10.0-20180129161428/
    Repo: http://build.eclipse.org/webtools/committers/wtp-R3.10.0-I/20180129161428/I-3.10.0-20180129161428/repository/

    b) Posted to the tycho-dev list and Jan suggested the issue in SSE is that we have somehow included two versions of Xalan in the target platform used to build SSE. I'll investigate that today, though I'm not sure how this is happening or why:

    "Sounds like you have two versions of xalan in the compilation classpath or in the p2 target platform and it's a matter of chance which one is picked."

    Meanwhile I've updated these BZs w/ status:

    https://bugs.eclipse.org/bugs/show_bug.cgi?id=530467
    https://bugs.eclipse.org/bugs/show_bug.cgi?id=530465
    https://bugs.eclipse.org/bugs/show_bug.cgi?id=530464


    Nick


    On Mon, Jan 29, 2018 at 2:46 PM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
    I've opened two bugs to track these issues:

    https://bugs.eclipse.org/bugs/show_bug.cgi?id=530465 - Remediation presented and two versions of server core in WTP update site 
    https://bugs.eclipse.org/bugs/show_bug.cgi?id=530464 - WTP update site should include redistribution of Jetty 9.4.7

    I've also opened this issue to track the Xalan debugger / SSE/ Tycho 1.1 issue:

    https://bugs.eclipse.org/bugs/show_bug.cgi?id=530467 - compile failed in org/eclipse/wst/xsl/xalan/debugger with Tycho 1.1.0-SNAPSHOT (3.10.0.M5)

    Has anyone made any progress on the Xalan issue?

    Nick

    On Mon, Jan 29, 2018 at 2:36 PM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
      Confirmed. To install this build you need to first add a link to the Jetty 9.4.7 site [1] in your Eclipse.

      [1] http://download.eclipse.org/jetty/updates/jetty-bundles-9.x/9.4.7.v20170914/

      However I'm also seeing remediation trying to install this:

      Cannot complete the install because of a conflicting dependency.
        Software being installed: Server Core 1.10.0.v201711201954 (org.eclipse.wst.server.core 1.10.0.v201711201954)
        Software being installed: Eclipse Web Developer Tools 3.9.2.v201801221842 (org.eclipse.wst.web_ui.feature.feature.group 3.9.2.v201801221842)
        Only one of the following can be installed at once: 
          Server Core 1.10.0.v201711201954 (org.eclipse.wst.server.core 1.10.0.v201711201954)
          Server Core 1.10.0.v201705172051 (org.eclipse.wst.server.core 1.10.0.v201705172051)

      I'll look into WHY we have two versions of that plugin in the repo... we shouldn't have both.



      On Mon, Jan 29, 2018 at 1:45 PM, Carl Anderson <ccc@xxxxxxxxxx> wrote:
      Folks,

      This was all caused by Nick's fix to bug 527813 , which moved WTP from including the two Jetty plugins that the Platform does not ship, to simply requiring those plugins. BIRT includes the 9.4.5 version of those plugins (yet, the platform, and WTP, moved up to Jetty 9.4.7 for Oxygen.2 and Photon M4). If you look at comment #31 on that bug, you will find the link to the repo that you need to add in order to resolve this dependency during WTP's install.

      Nick,

      Due to issues that have arisen with adopters using Oxygen.2 and everyone using Photon M5, should we revisit the decision to move this from an include to a require? Right now, WTP is at the mercy of other teams like BIRT, which includes the 9.4.5 versions of these Jetty plugins in Photon. The Eclipse Platform does not include all of the Jetty plugins that WTP requires, and there is no direct contribution of the Jetty plugins to the simultaneous release aggregation. From a release engineering standpoint, this is not ideal.

      FWIW,

      - Carl Anderson
      WTP Releng project lead

      Inactive hide details for Robert Stryker ---01/29/2018 11:46:14 AM---Victor and I are both having problems installing wtp's buiRobert Stryker ---01/29/2018 11:46:14 AM---Victor and I are both having problems installing wtp's build on a platform m5 (or in victor's case,

      From:       Robert Stryker <stryker@xxxxxxxxxx>
      To:       Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>
      Cc:       Carl Anderson <ccc@xxxxxxxxxx>, Nitin Dahyabhai <nitind@xxxxxxxxx>, Keith Chong <kchong@xxxxxxxxxx>, Victor Rubezhny <vrubezhn@xxxxxxxxxx>
      Date:       01/29/2018 11:46 AM
      Subject:       Re: [wtp-releng] Smoke Test Request for WTP 3.10.0 I-build



      Victor and I are both having problems installing wtp's build on a platform m5 (or in victor's case, m4?)

      The issue seems to be that When installing WTP 3.10.M5 smoke test candidate, could not find org.eclipse.jetty.webapp [9.4.7,10.0.0).  Servertools seems to need this library and cannot find it.

      Even though the UI insists it won't install servertools, it still does, but it installs a lower version than expected.

      696    STARTING    org.eclipse.wst.server.core_1.10.0.v201705172051
      697    STARTING    org.eclipse.wst.server.discovery_1.3.100.v201705102053
      698    STARTING    org.eclipse.wst.server.ui_1.5.400.v201705172051
      699    STARTING    org.eclipse.wst.server.ui.doc.user_1.1.600.v201309182117
      700    RESOLVED    org.eclipse.wst.server.ui.infopop_1.1.200.v201309182117

      This is pretty confusing for me. Remediation insisted it would not install it, but it installed it anyway, but somehow found a downgraded version despite using the http://build.eclipse.org/webtools/committers/wtp-R3.10.0-I/20180125000115/I-3.10.0-20180125000115/repository/  update site.

      Very weird behavior

      - Rob


      On Fri, Jan 26, 2018 at 4:44 PM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
          And now the build is failing because Tycho 1.1.0-SNAPSHOT says:

          [DEBUG] Closing connection to remote
          [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.1.0-SNAPSHOT:compile (default-compile) on project org.eclipse.wst.xsl.xalan: Compilation failure: Compilation failure:
          [ERROR] /jobs/genie.webtools/WTP-R3_10_Integration/workspace/webtools.sourceediting/xsl/bundles/org.eclipse.wst.xsl.xalan/src-debugger/org/eclipse/wst/xsl/xalan/debugger/XalanDebugger.java:[46]
          [ERROR] lastTransformerInChain.getSerializationHandler().flushPending();
          [ERROR]                        ^^^^^^^^^^^^^^^^^^^^^^^
          [ERROR] The method getSerializationHandler() is undefined for the type TransformerImpl
          [ERROR] /jobs/genie.webtools/WTP-R3_10_Integration/workspace/webtools.sourceediting/xsl/bundles/org.eclipse.wst.xsl.xalan/src-debugger/org/eclipse/wst/xsl/xalan/debugger/XalanStyleFrame.java:[131]
          [ERROR] currentLine = e.m_styleNode.getEndLineNumber();
          [ERROR]                             ^^^^^^^^^^^^^^^^
          [ERROR] The method getEndLineNumber() is undefined for the type ElemTemplateElement
          [ERROR] 2 problems (2 errors)

          Back to you in the studio, sourceediting folks.

          https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/WTP-R3_10_Integration/237/console



          On Fri, Jan 26, 2018 at 1:52 PM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
          I pulled in the latest commits from these 4 repos:

          * 0bc38df - (HEAD -> master, origin/master) pull latest from  webtools.javaee webtools.jsdt webtools.jsf webtools.sourceediting nboldt@xxxxxxxxxx (6 minutes ago)

          Build 235 triggered using Tycho 1.1.0-SNAPSHOT and using M5 instead of an I build of Eclipse Platform.

          https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/WTP-R3_10_Integration/235/parameters/


          On Fri, Jan 26, 2018 at 1:45 PM, Carl Anderson <ccc@xxxxxxxxxx> wrote:



          --
          Nick Boldt
          Senior Software Engineer, RHCSA
          Productization Lead :: JBoss Tools & Dev Studio
          IM: @nickboldt / @nboldt /           http://nick.divbyzero.com
      TRIED. TESTED. TRUSTED.
      TRIED. TESTED. TRUSTED.





      _______________________________________________
      wtp-releng mailing list
      wtp-releng@xxxxxxxxxxx
      To change your delivery options, retrieve your password, or unsubscribe from this list, visit
      https://dev.eclipse.org/mailman/listinfo/wtp-releng



      --
      Nick Boldt
      Senior Software Engineer, RHCSA
      Productization Lead :: JBoss Tools & Dev Studio
      IM: @nickboldt / @nboldt / http://nick.divbyzero.com
TRIED. TESTED. TRUSTED.

TRIED. TESTED. TRUSTED.



    --
    Nick Boldt
    Senior Software Engineer, RHCSA
    Productization Lead :: JBoss Tools & Dev Studio
    IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.



--
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.
@ @redhatnews      Red Hat
_______________________________________________
wtp-releng mailing list
wtp-releng@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_wtp-2Dreleng&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=6JCYBixIS0G6Rj43h5xZSA&m=FWf-wSfe1YZvU55jytAPBda4PkCnpZrdTv2TQl9EGpY&s=1rh4Yx6SqZIXwkN1LJRgeZDdr5E5xq3EJJYUEGvBoGg&e=



_______________________________________________
wtp-releng mailing list
wtp-releng@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-releng



--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

Back to the top