Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-releng] Branch verification for WTP 3.9.2 build

Nick,


a) It has been a long-standing WTP policy that changes to what branch is used for what build are announced on wtp-releng. The main reason for that is so that the various releng committers are in sync about what builds from where. Now, I would argue that we never have to get an update about the master version of repositories.txt - it should always build from the master branch of each repo, unless there are special circumstances. It is the maintenance branch of that file that should be changed as necessary. Furthermore, this goes for any change needed to repositories.txt, even the merging of repos.

b) All projects should tag for every release. However, the tag that they use is sometimes different from the tag that others use- most notably Dali, which has their own release version. WTP allows its sub-projects to do separate releases, as needed, and Dali has taken advantage of that in the past. As such, there is no specific tag that is used across all repositories. Along these same lines, no PMC member has "God Mode" authority (not eve David Williams!) - it is the responsibility of the project leads to tag their repositories. There is no penalty if that is not done. (But it can be painful for WTP Releng if a rebuild or patch is needed on a certain stream where not all of the repos were properly tagged).

Now, as with any other open-source policy, these policies are debatable/changeable. Let me know if you have any questions/comments/concerns or proposed changes.

FWIW,

- Carl Anderson
WDT Releng project lead
Inactive hide details for Nick Boldt ---10/12/2017 10:54:08 AM---So, as I'm new here... two questions: a) do we need to announcNick Boldt ---10/12/2017 10:54:08 AM---So, as I'm new here... two questions: a) do we need to announce changes to

From: Nick Boldt <nboldt@xxxxxxxxxx>
To: Victor Rubezhny <vrubezhny@xxxxxxxxxx>, Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>
Date: 10/12/2017 10:54 AM
Subject: Re: [wtp-releng] Branch verification for WTP 3.9.2 build
Sent by: wtp-releng-bounces@xxxxxxxxxxx




So, as I'm new here... two questions:

a) do we need to announce changes to http://git.eclipse.org/c/webtools/webtools.releng.aggregator.git/tree/scripts/repositories.txt (and other branches) ? If so, is this the list on which to announce it?

b) should all projects branch or tag for every release, even if nothing has changed since a previous release? If so, there's less need for a repositories.txt file since it can safely be assumed that every project is using the same branch/tag. (In JBoss Tools we automatically tag after each release (from the SHAs used for the release), and automatically branch as needed before a release or when forking maintenance from master.)

If you'd like something like automated tagging/branching for the webtools.* projects, we need either a bot user or a script that can be run by a PMC member w/ God Mode powers in all the repos. Then the script can be run quickly on one person's machine (or in Jenkins) and there need no longer be reminders sent to a dozen people, and confusion about which branch/tag to use.

WDYT?

Nick

On Wed, Oct 11, 2017 at 5:29 PM, Victor V. Rubezhny <vrubezhn@xxxxxxxxxx> wrote:
    Yes you're right Carl, but historically we've never were creating a maintenance branch if we have nothing to push into it. And this time we have nothing new to push into jsdt/sourceediting maintenance. As such, we've just tagged them as R3_9_1 and never branched.

    That was probably my faults, as I didn't wrote about the need to switch jsdt/maintenance build to use R3_9_1 tag, and the need to create R3_9_1a tag (as well as any others R3_9_x tags) basing on the same commit as R3_9_1 (or branch it before R3_9_1a). Sorry about that mess.

    Thanks,
    Victor




    On 10/11/2017 07:20 PM, Carl Anderson wrote:
        Victor,

        Nick did make that change directly to the file. However, no note was sent to WTP releng stating that that tag should be used for the WTP 3.9.1a build and all future WTP 3.9.x builds. As such, as part of the build preparation for WTP 3.9.2, I reverted all of the R3_9_1 tags back to master.
        Now, with the note you just sent, WTP Releng now understands that jsdt and sourceediting should build from the R3_9_1 tag for the R3_9_maintenance build. I just reverted the change to master that I made for these two repositories.
        Furthermore, as a "best practice", I recommend that a R3_9_maintenance branch be created from the R3_9_1 tag for these repositories. The build would then be updated to use that branch, and if/when a change is needed for WTP 3.9.x in either of those repositories, the branch will already be there and the build will already be configured. However, if you wish to proceed with just the R3_9_1 tag in the build, that is acceptable. (But when a change is needed, the branch needs to come from R3_9_1 and not master.)

        FWIW,

        - Carl Anderson
        WTP Releng project lead

        Inactive hide details for "Victor V. Rubezhny" ---10/11/2017 12:23:59 PM---Carl, I'm sorry. I thought it was fixed, but just re"Victor V. Rubezhny" ---10/11/2017 12:23:59 PM---Carl, I'm sorry. I thought it was fixed, but just realized that we have the

        From:         "Victor V. Rubezhny" <vrubezhn@xxxxxxxxxx>
        To:         wtp-releng@xxxxxxxxxxx
        Date:         10/11/2017 12:23 PM
        Subject:         Re: [wtp-releng] Branch verification for WTP 3.9.2 build
        Sent by:         wtp-releng-bounces@xxxxxxxxxxx




        Carl,

        I'm sorry. I thought it was fixed, but just realized that we have the only Gerrit Change created for that and that change is not pushed yet.

        Please set for R3_9_maintenance branch:

        webtools.jsdt: R3_9_1
        webtools.sourceediting: R3_9_1

        If it wasn't set when producing WTP 3.9.2, then I must request the respin of it after the change above is pushed.
        Sorry for not spotting this earlier.

        Regards,
        Victor.

        On 10/11/2017 06:13 PM, Victor V. Rubezhny wrote:
                Hello Carl,

                Don't forget about two repos those are to be build from R3_9_1 tag:

                webtools.jsdt: R3_9_1
                webtools.sourceediting: R3_9_1

                Which was set, but then it looks like reverted for some reason. We must not build two of these from master in 3.9.x.

                Regards,
                Victor

                On 10/11/2017 05:56 PM, Carl Anderson wrote:
                        Folks,

                        Since it is a major revert, I just want to make sure that we are building from the correct branches for all of the repositories as we build for WTP 3.9.2. So far, two repositories are building off of the R3_9_maintenance branch:

                        webtools.jsf.tests
                        webtools.servertools

                        All other repositories are building off of master. If this is not correct, please send a note to wtp-releng with the correct branch information for the WTP 3.9.2 build.
                        Please let me know if you have any questions/comments/concerns.

                        Sincerely,

                        - Carl Anderson
                        WTP Releng project lead


                        _______________________________________________
                        wtp-releng mailing list
                        wtp-releng@xxxxxxxxxxx
                        To change your delivery options, retrieve your password, or unsubscribe from this list, visit
                        https://dev.eclipse.org/mailman/listinfo/wtp-releng

        _______________________________________________
        wtp-releng mailing list
        wtp-releng@xxxxxxxxxxx
        To change your delivery options, retrieve your password, or unsubscribe from this list, visit
        https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_wtp-2Dreleng&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=6JCYBixIS0G6Rj43h5xZSA&m=u9Hm0xp80zoUoTivc9T4XYFxOm8l8bxC6rxmoCo7QAI&s=KT05pbSp0b7q_L-Fv4t5Drx10IFTp4X28RAoO9alpfU&e=



        _______________________________________________
        wtp-releng mailing list
        wtp-releng@xxxxxxxxxxx
        To change your delivery options, retrieve your password, or unsubscribe from this list, visit
        https://dev.eclipse.org/mailman/listinfo/wtp-releng



    _______________________________________________
    wtp-releng mailing list
    wtp-releng@xxxxxxxxxxx
    To change your delivery options, retrieve your password, or unsubscribe from this list, visit
    https://dev.eclipse.org/mailman/listinfo/wtp-releng



--
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.
@ @redhatnews      Red Hat_______________________________________________
wtp-releng mailing list
wtp-releng@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_wtp-2Dreleng&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=6JCYBixIS0G6Rj43h5xZSA&m=_bd-mMszIVzbiREqndLteuXutpx4mLBE-NhkWdsQi-8&s=cPYVqHvMRRhXGjWz8Z81QOdT28La6gN-9AZxqmYYAMw&e=

Back to the top