RE: [wtp-releng] Here's a new build breaker .... PDE doesn't allowcycles

["Giormov, Dimitar" <dimitar.giormov@xxxxxxx>]

It was me.

Sory about that.

I have checked for dependencies and fixed a direct one, but I should have checked again. (If you have all the projects imported from CVS the error is marked, if you miss one and use it from target platform it is not)

 

 

The cycle dependency is fixed.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=226583

 

I may be wrong, but from my point of view there is something wrong with the plugin structure, from architectural point of view the "org.eclipse.jst.j2ee.navigator.ui" should be base for "org.eclipse.jst.j2ee.servlet.ui" and "org.eclipse.jst.jee.ui", and should not refer either of them, I think similar problem is with ejb.ui. It is worth noting that the class IJ2EEWizardConstants is causing these dependencies, and I could not find its purpose.

 

 

 

 

From: Raev, Kaloyan
Sent: Wednesday, April 16, 2008 9:39 AM
To: Giormov, Dimitar
Subject: FW: [wtp-releng] Here's a new build breaker .... PDE doesn't allowcycles between packages, ....

 

It seems to be our latest changes.

 

---

From: wtp-releng-bounces@xxxxxxxxxxx [mailto:wtp-releng-bounces@xxxxxxxxxxx] On Behalf Of David M Williams
Sent: Wednesday, April 16, 2008 7:08 AM
To: Webtools releng discussion list
Subject: [wtp-releng] Here's a new build breaker .... PDE doesn't allowcycles between packages, ....

I bet someone even turned off the error level warnings so they wouldn't to see those errors, right? (I only know that because that's what I did recently on another project :).

<quote>
A cycle was detected when generating the classpath org.eclipse.jst.jee.ui_1.0.100.v200804151744, org.eclipse.jst.j2ee.navigator.ui_1.1.200.v200803250300, org.eclipse.jst.servlet.ui_1.1.200.v200804151744, org.eclipse.jst.jee.ui_1.0.100.v200804151744.
</quote>

Looks like it's the JEE teams?