Re: [virgo-dev] Virgo Tools and Server Editor

[Daniel Marthaler <dmarthaler@xxxxxxx>]

Hi GianMaria

If you need someone who goes over code changes to have second pair of eyes reviewing changes let me know, i am happy to help. 

Regards,

Dani

Am 04.10.2015 um 16:25 schrieb Giamma <gm.romanato@xxxxxxxxx>:

On Sun, Oct 4, 2015 at 4:11 PM Florian Waibel <fwaibel@xxxxxxxxxxxxxxxxx> wrote:> Should this be tracked by a bugzilla entry?

+1 for creating bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=478976

I had a look at bugzilla and found out that a previous committer created a similar entry in 2012, so I thought it would be appropriate.

In general I like code reviews. Personally I can not promise to review code changes carefully and as quickly as I would like. So I wouldn’t enforce this policy
currently for Virgo. On the other hand please do not hesitate to ask actively for reviews if you think a second opinion is useful.

Ok, I'll try to ask for code review when the changes won't be trivial.

GianMaria.

 

_______________________________________________
virgo-dev mailing list
virgo-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/virgo-dev