Re: [virgo-dev] Jboss Migrating to Virgo

[Dmitry Sklyut <dmitry@xxxxxxxxxxx>]

Another interesting class to expose or to move to util.parser.manifest.

org.eclipse.virgo.kernel.artifact.internal.BundleManifestUtils

Abstracts operations IO when trying to look up a Manifest.mf and deals with jar vs. exploded directory.

Not sure if there any other utilities within virgo that deal with looking up readers/urls from java.io.File (directory or jar).

For example:

Reader searchFileFor(File file, String expectedPathInFile);

searchFileFor(file, "META-INF/application.xml").

Regards,
Dmitry

On Wed, Nov 17, 2010 at 4:21 PM, Glyn Normington <gnormington@xxxxxxxxxx> wrote:

Hi Dmitry

I haven't been into that area of the code for a long time, so what you say sounds plausible. Thanks!

Regards,
Glyn

On 17 Nov 2010, at 19:42, Dmitry Sklyut wrote:

Glyn,

After looking at ArtifactIdentityDeterminer both Standard and Delegating, it looks like the job can be done with just ArtifactBridge without custom ArtifactIdentityDeterminer for ear.
As long as bridge is published it will be queried first for AftifactDescriptor.  The only benefit that custom ArtifactIdentityDeterminer can provide is examining the file extension.

WDYT?

Regards,
Dmitry

On Tue, Nov 16, 2010 at 10:59 AM, Glyn Normington <gnormington@xxxxxxxxxx<mailto:gnormington@xxxxxxxxxx>> wrote:
On 16 Nov 2010, at 15:13, Dmitry Sklyut wrote:

There are few other things you have to be aware of:

1. org.eclipse.virgo.repository.AftifactBridge
2.org.eclipse.virgo.kernel.install.artifact.InstallArtifact

#1 is used to read deployed artifact and generate descriptors for pipeline to consume.  #2 encapsulate lifecycle logic for a specific type of an installed artifact.

One correction.

Actually #1 is used by the Virgo repository to determine the (type, name, version) identity of an artifact found while scanning the repository. Lin will need to implement this to make the repository recognize EARs.

org.eclipse.virgo.kernel.install.artifact.ArtifactIdentityDeterminer is the interface for determining the identity of an artifact which is being deployed. Lin will need to implement this so EARs can be deployed, e.g. by dropping in the pickup directory.


I have been trying to find the time to write up something concreate on custom deployed artifacts for months now, but work and life gets in the way :)

I know the feeling.


If you are interested in participating on working on a prototype, I can throw together an initial implementation on github and we can collaborate on implementation.
There are a lot of edge cases that might be specific to your deployment structure that would be missed without your input.  For example start order of artifacts.

This is a great suggestion and would allow us to identify and answer the remaining questions about adding an artifact type.

Regards,
Glyn
_______________________________________________
virgo-dev mailing list

virgo-dev@xxxxxxxxxxx<mailto:virgo-dev@xxxxxxxxxxx>

https://dev.eclipse.org/mailman/listinfo/virgo-dev

<ATT00001..txt>

_______________________________________________
virgo-dev mailing list
virgo-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/virgo-dev