Re: [tycho-dev] Update p2 (bug 352883)

[Igor Fedorenko <ifedorenko@xxxxxxxxxxxx>]

I finally got some time to look at this. All failures are caused by
macosx/carbon/x86 fragments not being available in Juno (I have not
checked, but guess this platform has been retired). I updated all
affected tests to macosx/cocoa/x86_64 for now, but this is another
reminder we should get rid of -Dtycho.targetPlatform and run tests
against stable repositories.

--
Regards,
Igor

On 11-08-23 12:21 PM, Igor Fedorenko wrote:
> The following ITs fail after I upgraded equinox and jdt. Will need to
> find time to debug this.
>
> testEclipseSourceBundleManifestAttributes(org.eclipse.tycho.test.TYCHO300launcherIcons.LauncherIconsTest)
>
> test(org.eclipse.tycho.test.mngeclipse1105PackageRootFiles.PackageRootFilesTest)
>
> exportProduct(org.eclipse.tycho.test.TYCHO232multiplatformProduct.MultiplatformProductTest)
>
> testBasic(org.eclipse.tycho.test.TYCHO0294ProductP2TargetPlatformResolver.ProductP2TargetPlatformResolverTest)
>
>
> --
> Regards,
> Igor
>
>
> On 11-08-23 10:01 AM, Oberlies, Tobias wrote:
> > You are probably right. It seemed to work with only p2 updated, but we
> > don't really have to test if Equinox can be mixed in different versions.
> >
> > I've done the OSGi runtime update. Could you update the versions in
> > the root POM? IIRC this requires the Maven central upload. See also
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=352883
> >
> > Best regards
> > Tobias
> >
> > Igor Fedorenko wrote:
> > > There are two cases, iirc. The code that runs inside Maven jvm (target
> > > platform resolver, mainly) will use org.eclipse.osgi bundle that is
> > > defined in tycho pom.xml file. The code that runs in external jvm (p2
> > > publisher and others), will use version of the bundle packaged in
> > > tycho-p2-runtime.
> > >
> > > To keep things simple, I would update everything to Juno M1. I can
> > > deploy equinox and jdt to Maven central, if you want.
> > >
> > > --
> > > Regards,
> > > Igor
> > >
> > > On 11-08-22 3:30 PM, Oberlies, Tobias wrote:
> > > > Hi Igor,
> > > > I've just started working on
> > > > _https://bugs.eclipse.org/bugs/show_bug.cgi?id=352883_, and I was
> > > > wondering if it makes any difference if we update only the p2 stuff or
> > > > everything from Equinox (incl. the version of org.eclipse.osgi).
> > > > Is my assumption correct, that the org.eclipse.osgi bundle is loaded by
> > > > the Maven class loader?
> > > > Regards
> > > > Tobias
> > _______________________________________________
> > tycho-dev mailing list
> > tycho-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev