Re: [technology-pmc] Fwd: Fw: [eclipse/ice] January initial contribution

[Wayne Beaton <wayne@xxxxxxxxxxx>]

No IP review is required. EOL changes don't count.

As a general rule, we're only concerned with actual intellectual property contributions.

Wayne

On 25/07/16 10:48 AM, Jay Jay Billings wrote:

Dear PMC,

Can you please advise me on the pull request below? Jonah Graham cleaned up a bunch of gunk in ICE as part of the January initial contribution. Most of it is end of line changes, but those total up to a couple of thousand line. Otherwise it was only 101 insertions. 

Should this go through an IP review? Happy to submit it, but just wanted to check.

Jay

---------- Forwarded message ----------
From: Billings, Jay Jay <billingsjj@xxxxxxxx>
Date: Mon, Jul 25, 2016 at 10:46 AM
Subject: Fw: [eclipse/ice] January initial contribution cleanup (#248)
To: "jayjaybillings@xxxxxxxxx" <jayjaybillings@xxxxxxxxx>

---

From: Jonah Graham <notifications@xxxxxxxxxx>
Sent: Monday, July 25, 2016 10:20 AM
To: eclipse/ice
Cc: Billings, Jay Jay; Comment
Subject: Re: [eclipse/ice] January initial contribution cleanup (#248)

 

OK, for the review it may be helpful to add these stats showing that excluding EOL changes, there is only 101 insertions.

$ git diff --shortstat jonah/january_copyright_cleanup..origin/jay/january
108 files changed, 2257 insertions(+), 2387 deletions(-)

$ git diff --ignore-space-at-eol --shortstat jonah/january_copyright_cleanup..origin/jay/january
108 files changed, 101 insertions(+), 231 deletions(-)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

--

Jay Jay Billings

Oak Ridge National Laboratory

Twitter Handle: @jayjaybillings

_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/technology-pmc

--
Wayne Beaton
@waynebeaton
The Eclipse Foundation