Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [technology-pmc] NatTable Release 1.2.0 - Request for approval
>> does that mean that all packages are exported from the NatTable bundle(s)?

yes

>> sounds like it needs a major version increase (2.0.0)

from the OSGi versioning principles you are right. but this leads to a discussion product vs. bundle version. The breaking changes were necessary because I'm still cleaning up the mess my predecessors left me.

Updating the major version would lead to confusions in the NatTable community since I communicated that 2.0 would be a NatTable version with new architecture to support additional UI toolkits. 

>> maybe those interfaces should have had a @noimplement in their signature since day 1?

as far as I understand @noimplement I would agree

On Mon, Jan 19, 2015 at 11:03 PM, Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx> wrote:
Not being part of the PMC the question is maybe those interfaces should
have had a @noimplement in their signature since day 1?

Tom

On 19.01.15 22:57, Eric Rizzo wrote:
> Dirk,
>
> If there are no internal packages, does that mean that all packages are
> exported from the NatTable bundle(s)? If so then this really sounds like
> it needs a major version increase (2.0.0) because adding to interfaces
> is a breaking change. Even if the interfaces aren't "supposed" to be
> used by clients or extenders, they could be.
>
> I'm basing these thoughts on https://wiki.eclipse.org/Eclipse/API_Central
>
>
>
> Other PMC members, any thoughts?
>
> Eric
>
>
>
> On 2015-01-19 14:35, Dirk Fauth wrote:
>
>> Hi Eric,
>>
>> since we do not have "internal" packages, those changes are not
>> backwards-compatible. This is the reason why I mention them in the New
>> & Noteworthy.
>>
>> Most of the interfaces are mainly used internally, but NatTable is
>> treated as "open framework", so if users customized their table in
>> that detail, they will face issues. Users that simply use NatTable
>> with its configuration possibilities won't suffer.
>>
>> Greez,
>> Dirk
>>
>> On Mon, Jan 19, 2015 at 7:15 PM, Eric Rizzo <eclipse-mail@xxxxxxxxxxxx
>> <mailto:eclipse-mail@xxxxxxxxxxxx>> wrote:
>>
>>     On 2015-01-19 11:41, Dirk Fauth wrote:
>>
>>         Hi,
>>
>>         I request approval for the NatTable 1.2.0 release.
>>
>>         https://projects.eclipse.org/projects/technology.nebula.nattable/reviews/1.2.0-release-review
>>
>>         Greez,
>>         Dirk
>>
>>
>>
>>     Dirk,
>>
>>     It's not 100% clear from the release material, are there any
>>     backwards-incompatible changes in non-internal packages? I'm
>>     asking only because much of the New & Noteworthy talks about
>>     additions to interfaces but it doesn't say if those are in
>>     packages labeled as "internal."
>>
>>     Thanks,
>>     Eric
>>
>>
>>
>>
>>
>>     _______________________________________________
>>     technology-pmc mailing list
>>     technology-pmc@xxxxxxxxxxx <mailto:technology-pmc@xxxxxxxxxxx>
>>     To change your delivery options, retrieve your password, or
>>     unsubscribe from this list, visit
>>     https://dev.eclipse.org/mailman/listinfo/technology-pmc
>>
>>
>> _______________________________________________
>> technology-pmc mailing list
>> technology-pmc@xxxxxxxxxxx <mailto:technology-pmc@xxxxxxxxxxx>
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/technology-pmc
>
>
>
>
>
>
> _______________________________________________
> technology-pmc mailing list
> technology-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/technology-pmc
>


--
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/technology-pmc

Back to the top